Intermittent playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357

RESOLVED FIXED in FxOS-S7 (18Sep)

Status

Firefox OS
Gaia::Music
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: hub)

Tracking

unspecified
FxOS-S7 (18Sep)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
00:39:43 INFO - TEST-START | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357
00:40:20 INFO - TEST-UNEXPECTED-FAIL | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357
00:40:20 INFO - Crash detected but error running stackwalk
00:40:20 INFO - TEST-END | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357 took 22357 ms
Comment hidden (Treeherder Robot)
(Assignee)

Comment 2

3 years ago
Will look at it.
Assignee: nobody → hub
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 14

3 years ago
This is spiking badly. Can we please get some eyes on it soon?
Flags: needinfo?(gaye)
(Reporter)

Comment 15

3 years ago
Nevermind, this was merged-around bustage which has already been backed out from Gaia.
Flags: needinfo?(gaye)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 17

3 years ago
Yeah I didn't think it was related to the first failure.
(Assignee)

Comment 18

3 years ago
bug 1159028 was the backed out patch causing the failures above.
(Reporter)

Comment 19

3 years ago
The original failure this was filed for was a one-off over 2 months ago. Let's close this out to avoid any future false positives.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: intermittent-failure
Resolution: --- → WORKSFORME
(Assignee)

Comment 20

3 years ago
I have seen it fail locally. Reopening. Will submit a patch.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Assignee)

Updated

3 years ago
Status: REOPENED → ASSIGNED
Created attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master
(Assignee)

Comment 22

3 years ago
Created attachment 8643000 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233

I hit that test failure testing something else. This makes it more robust.
Attachment #8643000 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Comment 23

3 years ago
Comment on attachment 8643000 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233

I didn't realise autolander was back.
Attachment #8643000 - Attachment is obsolete: true
Attachment #8643000 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Comment 24

3 years ago
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

This is the one PR.
Attachment #8642999 - Attachment description: [gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Updated

3 years ago
Attachment #8642999 - Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233 → [gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master
(Assignee)

Comment 25

3 years ago
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

cancelling review for now. it seems that this fix has side effects, at least locally.
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Comment 26

3 years ago
Yep, test are orange on this. Need to dig it more.
(Assignee)

Comment 27

3 years ago
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

This should make the test more reliable now.

(this is Music OGA)
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)

Comment 28

3 years ago
What are the changes in the Ogg files?
Flags: needinfo?(hub)
(Assignee)

Comment 29

3 years ago
The commit tells it: they are now 10sec silence. Instead one sample. (I have a separate commit for it and intend to keep it that way)
Flags: needinfo?(hub)

Comment 30

3 years ago
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

In that case, r=me
Attachment #8642999 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 31

3 years ago
Merged
https://github.com/mozilla-b2g/gaia/commit/13ed13e061bd4f20de47c196469a63706fe866a7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.