Closed Bug 1157782 Opened 9 years ago Closed 9 years ago

Intermittent playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S7 (18Sep)

People

(Reporter: RyanVM, Assigned: hub)

References

()

Details

Attachments

(1 file, 1 obsolete file)

00:39:43 INFO - TEST-START | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357
00:40:20 INFO - TEST-UNEXPECTED-FAIL | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357
00:40:20 INFO - Crash detected but error running stackwalk
00:40:20 INFO - TEST-END | apps/music/test/marionette/playlist_test.js | Music player playlist Default playlists Shuffle all sort order. moztrap:2357 took 22357 ms
Will look at it.
Assignee: nobody → hub
This is spiking badly. Can we please get some eyes on it soon?
Flags: needinfo?(gaye)
Nevermind, this was merged-around bustage which has already been backed out from Gaia.
Flags: needinfo?(gaye)
Yeah I didn't think it was related to the first failure.
bug 1159028 was the backed out patch causing the failures above.
The original failure this was filed for was a one-off over 2 months ago. Let's close this out to avoid any future false positives.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
I have seen it fail locally. Reopening. Will submit a patch.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Status: REOPENED → ASSIGNED
I hit that test failure testing something else. This makes it more robust.
Attachment #8643000 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8643000 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233

I didn't realise autolander was back.
Attachment #8643000 - Attachment is obsolete: true
Attachment #8643000 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

This is the one PR.
Attachment #8642999 - Attachment description: [gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)
Attachment #8642999 - Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31233 → [gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

cancelling review for now. it seems that this fix has side effects, at least locally.
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)
Yep, test are orange on this. Need to dig it more.
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

This should make the test more reliable now.

(this is Music OGA)
Attachment #8642999 - Flags: review?(squibblyflabbetydoo)
What are the changes in the Ogg files?
Flags: needinfo?(hub)
The commit tells it: they are now 10sec silence. Instead one sample. (I have a separate commit for it and intend to keep it that way)
Flags: needinfo?(hub)
Comment on attachment 8642999 [details] [review]
[gaia] hfiguiere:bug1157782-shuffle-test > mozilla-b2g:master

In that case, r=me
Attachment #8642999 - Flags: review?(squibblyflabbetydoo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/13ed13e061bd4f20de47c196469a63706fe866a7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: