Closed Bug 1157835 Opened 5 years ago Closed 5 years ago

Remove the MSVC_ENABLE_PGO flag

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(2 files, 1 obsolete file)

moz.build files (automated, with hand-fixup)
53.40 KB, patch
glandium
: review+
Details | Diff | Splinter Review
python files (by hand)
5.00 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
MSVC_ENABLE_PGO has had no effect after bug 1084162 landed six months ago.
Attachment #8596889 - Flags: review?(mh+mozilla)
Attached patch python files (by hand) (obsolete) — — Splinter Review
Attachment #8596891 - Flags: review?(mh+mozilla)
Attachment #8596891 - Attachment is obsolete: true
Attachment #8596891 - Flags: review?(mh+mozilla)
Attachment #8596892 - Flags: review?(mh+mozilla)
Comment on attachment 8596889 [details] [diff] [review]
moz.build files (automated, with hand-fixup)

Review of attachment 8596889 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/skia/moz.build
@@ -880,5 @@
>              'trunk/src/opts/SkBlitRow_opts_SSE4_asm.S',
>          ]
>  
> -MSVC_ENABLE_PGO = True
> -

While you have it covered in the second patch, the generate_mozbuild.py change belongs in this patch.

Also note that gfx/angle/moz.build is generated by a generate_mozbuild.py that is *not* in the tree:
https://github.com/mozilla/angle/blob/mozilla/generate_mozbuild.py and that thus needs to be updated separately.
Attachment #8596889 - Flags: review?(mh+mozilla) → review+
Attachment #8596892 - Flags: review?(mh+mozilla) → review+
(It occurred to me that the mozbuild test files probably all belonged in the same patch too, so I gave up trying to be clever folded them together)

Thanks :kamidphish for landing the ANGLE change: https://github.com/mozilla/angle/commit/bf3e0dda41a23b1319e7ae224640acbc52401f83
https://hg.mozilla.org/mozilla-central/rev/76604a91617d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: 1159255
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.