Armen noticed this today on travis, I can reproduce locally with the below stack. If this isn't a quick fix I'll disable the test so we can continue using travis. 1:41.18 TEST_START: MainThread test_safe_browsing_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages 1:55.07 TEST_END: MainThread FAIL, expected PASS Traceback (most recent call last): File "/home/travis/.venv/local/lib/python2.7/site-packages/marionette_client-0.10-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/home/travis/build/mozilla/firefox-ui-tests/firefox_ui_tests/remote/security/test_safe_browsing_warning_pages.py", line 56, in test_warning_pages self.check_report_button(unsafe_page) File "/home/travis/build/mozilla/firefox-ui-tests/firefox_ui_tests/remote/security/test_safe_browsing_warning_pages.py", line 98, in check_report_button self.assertEquals(self.marionette.get_url(), self.browser.get_final_url(url)) AssertionError: u'https://support.mozilla.org/en-US/kb/how-does-phishing-and-malware-protection- [truncated]... != u'https://safebrowsing.google.com/safebrowsing/diagnostic?client=Firefox&hl=en-U [truncated]... - https://support.mozilla.org/en-US/kb/how-does-phishing-and-malware-protection-work?as=u&utm_source=inproduct + https://safebrowsing.google.com/safebrowsing/diagnostic?client=Firefox&hl=en-US&site=https://www.itisatrap.org/firefox/its-an-attack.html
Created attachment 8596832 [details] [review] PR with fix This looks like a simple timing issue. We're not waiting long enough to get the url we expect. Travis is ok with this fix.
Attachment #8596832 - Flags: review?(ahalberstadt)
Comment on attachment 8596832 [details] [review] PR with fix Lgtm!
Attachment #8596832 - Flags: review?(ahalberstadt) → review+
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
The change of code as done in this PR is not doing what you expect. Now the check for the target page will never fail because you have replaced the page loaded by the button click with the target page. I will file a follow-up bug to correct that.
You need to log in before you can comment on or make changes to this bug.