Closed
Bug 115791
Opened 23 years ago
Closed 23 years ago
Text selection in main browser window not highlighted
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
VERIFIED
FIXED
People
(Reporter: wtanaka, Assigned: mjudge)
References
()
Details
(Keywords: smoketest)
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.6+) Gecko/20011217
BuildID: 2001121721
In all pages, when I try to select text in the browser window, the selection
occurs (I can paste into an xterm), but the text does not appear highlighted in
the browser window. So it is impossible to tell visually what text is
highlighted and what text is not.
Reproducible: Always
Steps to Reproduce:
1. Start mozilla
2. Go to a webpage (say http://www.yahoo.com/)
3. Drag the mouse over some of the text
Actual Results: No visible change
Expected Results: The selection should have been highlighted in black on grey,
displaying what was currently selected
![]() |
||
Comment 1•23 years ago
|
||
What's the selection background color in your current gtk theme?
Reporter | ||
Comment 2•23 years ago
|
||
An additional fact which might be useful: This behavior is reproducable on pages
of all background colors (I assume -- I've tried white, black and grey) and also
occurs in text widgets (like the one I'm using now)
To answer Boris's question, my gtk theme background color appears (from
emperical evidence collected by running the "gnp" program) to be a blue-ish
gradient.
![]() |
||
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 3•23 years ago
|
||
The behavior is also reproducable after a restart (I tried it just now). The
reason I listed "Black on Grey" as the expected behavior is that's what I was
getting for the selection color just a few builds ago.
Comment 4•23 years ago
|
||
wfm in 2001121708 linux
not wfm in 2001121721 linux
Comment 5•23 years ago
|
||
Actually, this is independent of platform. In linux/win32/macos9 builds that I
made this evening, there is no highlighting of any selection, whether for a
drag selection in an HTML document, or just double-clicking or drag selecting
in a text field (e.g., the urlbar, or a HTML form).
Not particularly usable in this state. smoketest/blocker since many common
operations in the tests will be difficult to perform.
Comment 6•23 years ago
|
||
this wfm in 12-17-03 win2k installer.
Comment 7•23 years ago
|
||
I'm seeing this bug in 2001121806-trunk on Windows 98 using the non-talkback
.ZIP install.
Comment 8•23 years ago
|
||
its in 12-18-03.. w2k.. this really is bad, how did this find its way in?
Comment 9•23 years ago
|
||
looks like some possible crash landings happenend? ;)
Comment 10•23 years ago
|
||
lame guess fingered hyatt's fix for 112980. If someone has a build, can they
back this change out to verify? Here is the patch:
http://bugzilla.mozilla.org/attachment.cgi?id=62005&action=view
Comment 11•23 years ago
|
||
This happens in mail headers as well, i am not able to highlight the text in the
Subject line, it is possible though in the mail body
What, you're not guessing it's mjudge? He only landed major API changes to
selection yesterday.
Maybe the pres shell's mDisplayNonTextSelection needs to be initialized to
DISPLAY_TEXT & DISPLAY_IMAGES ? (Perhaps it should also become a PRInt16 and be
renamed to mSelectionFlags?)
Comment 14•23 years ago
|
||
On win32:
Any portion of a displayed mail cannot be selected (i.e. subject, body). In a
compose window, subject can't, but body can.
Comment 15•23 years ago
|
||
I've got this problem with 2001121803, win-sea-insatller, Win98SE. Did not have
with 20011214xx build. Time to confirm?
![]() |
||
Comment 16•23 years ago
|
||
*** Bug 115851 has been marked as a duplicate of this bug. ***
![]() |
||
Comment 17•23 years ago
|
||
*** Bug 115862 has been marked as a duplicate of this bug. ***
Comment 18•23 years ago
|
||
Also affects URLbar.
Comment 19•23 years ago
|
||
confirm problem both for text in the boby & URL bar for
build 2001121803 on Win NT
Comment 20•23 years ago
|
||
dbaron, I think that you mean ORing the two flags together. I did that, and
selection works for the content area. however, I can not select in the URL bar. :-/
Index: nsPresShell.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsPresShell.cpp,v
retrieving revision 3.492
diff -u -r3.492 nsPresShell.cpp
--- nsPresShell.cpp 18 Dec 2001 08:10:49 -0000 3.492
+++ nsPresShell.cpp 18 Dec 2001 20:15:44 -0000
@@ -1437,7 +1437,9 @@
mBidiLevel(BIDI_LEVEL_UNDEFINED),
#endif
mEnablePrefStyleSheet(PR_TRUE),
- mScrollingEnabled(PR_TRUE)
+ mScrollingEnabled(PR_TRUE),
+ mDisplayNonTextSelection(nsISelectionDisplay::DISPLAY_TEXT |
+ nsISelectionDisplay::DISPLAY_IMAGES)
{
NS_INIT_ISUPPORTS();
#ifdef MOZ_REFLOW_PERF
Assignee | ||
Comment 21•23 years ago
|
||
fixes checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
![]() |
||
Comment 22•23 years ago
|
||
*** Bug 115892 has been marked as a duplicate of this bug. ***
Comment 23•23 years ago
|
||
Confirming: The Win32 build from the 2001121814 directory seems fixed.
![]() |
||
Comment 24•23 years ago
|
||
*** Bug 115920 has been marked as a duplicate of this bug. ***
Updated•23 years ago
|
Status: RESOLVED → VERIFIED
Comment 25•23 years ago
|
||
verified with commercial builds:
linux 2001-12-19-08-trunk
mac 2001-12-19-04-trunk
osx 2001-12-19-04-trunk
![]() |
||
Comment 26•23 years ago
|
||
*** Bug 116054 has been marked as a duplicate of this bug. ***
![]() |
||
Comment 27•23 years ago
|
||
*** Bug 116080 has been marked as a duplicate of this bug. ***
Comment 28•23 years ago
|
||
I can confirm that this bug is fixed with build 2001121822 for solaris and
corresponding build on win2000.
You need to log in
before you can comment on or make changes to this bug.
Description
•