1157914 - Re-rendering the waterfall graph is really slow

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: treeherder-profile.json.gz

STR:

* Un-gzip and import the attached profile into the perf tool
* Select a sub region of the waterfall graph

* Start dragging the selected sub region left and right
or
* Start widening and shortening the selected sub region

ER:

No jank

AR:

Very janky

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Re-opening to just disable re-rendering until selection is done. Will let the other bug be for general perf improvements, where we need to just disable the re-rendering now for my dog-fooding sanity.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Don't re-render the graphs until selection is done

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=005886a96e63

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8599010 [details] [diff] [review]
Don't re-render the graphs until selection is done

Review of attachment 8599010 [details] [diff] [review]:
-----------------------------------------------------------------

Does this handle changing the selection scrolling with the mouse? r+ with comments addressed if it does, if not, let's do another patch/bug for that

::: browser/devtools/performance/views/details-js-flamegraph.js
@@ +8,5 @@
>   * controlled by DetailsView.
>   */
>  let JsFlameGraphView = Heritage.extend(DetailsSubview, {
>  
> +  shouldUpdateWhileMouseIsActive: true,

Add this to details-memory-flamegraph too

::: browser/devtools/performance/views/overview.js
@@ +79,5 @@
>      PerformanceController.off(EVENTS.CONSOLE_RECORDING_STOPPED, this._onRecordingStopped);
>      PerformanceController.off(EVENTS.CONSOLE_RECORDING_WILL_STOP, this._onRecordingWillStop);
>    }),
>  
> +  get isMouseActive() {

docs, is this for mousedown, while grabbing a selection handle, etc.

Also this will conflict with bug 1132758, whichever lands first

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Don't re-render the graphs until selection is done

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8599541 [details] [diff] [review]
Don't re-render the graphs until selection is done

Carrying over r+

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/38d27cf68e28

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/38d27cf68e28

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38d27cf68e28