Closed
Bug 1157914
Opened 9 years ago
Closed 9 years ago
Re-rendering the waterfall graph is really slow
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
(Whiteboard: [polish-backlog])
Attachments
(2 files, 1 obsolete file)
587.63 KB,
application/gzip
|
Details | |
6.92 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
STR: * Un-gzip and import the attached profile into the perf tool * Select a sub region of the waterfall graph * Start dragging the selected sub region left and right or * Start widening and shortening the selected sub region ER: No jank AR: Very janky
Assignee | ||
Updated•9 years ago
|
Whiteboard: [devedition-40]
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•9 years ago
|
||
Re-opening to just disable re-rendering until selection is done. Will let the other bug be for general perf improvements, where we need to just disable the re-rendering now for my dog-fooding sanity.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8599010 -
Flags: review?(jsantell)
Assignee | ||
Comment 4•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=005886a96e63
Comment 5•9 years ago
|
||
Comment on attachment 8599010 [details] [diff] [review] Don't re-render the graphs until selection is done Review of attachment 8599010 [details] [diff] [review]: ----------------------------------------------------------------- Does this handle changing the selection scrolling with the mouse? r+ with comments addressed if it does, if not, let's do another patch/bug for that ::: browser/devtools/performance/views/details-js-flamegraph.js @@ +8,5 @@ > * controlled by DetailsView. > */ > let JsFlameGraphView = Heritage.extend(DetailsSubview, { > > + shouldUpdateWhileMouseIsActive: true, Add this to details-memory-flamegraph too ::: browser/devtools/performance/views/overview.js @@ +79,5 @@ > PerformanceController.off(EVENTS.CONSOLE_RECORDING_STOPPED, this._onRecordingStopped); > PerformanceController.off(EVENTS.CONSOLE_RECORDING_WILL_STOP, this._onRecordingWillStop); > }), > > + get isMouseActive() { docs, is this for mousedown, while grabbing a selection handle, etc. Also this will conflict with bug 1132758, whichever lands first
Attachment #8599010 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8599010 -
Attachment is obsolete: true
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8599541 [details] [diff] [review] Don't re-render the graphs until selection is done Carrying over r+
Attachment #8599541 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/38d27cf68e28
Whiteboard: [devedition-40] → [devedition-40][fixed-in-fx-team]
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38d27cf68e28
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Updated•9 years ago
|
Whiteboard: [devedition-40] → [polish-backlog]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•