1157916 - "start" and "end" marker times should be shown in marker details

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I don't really care about start/end -- I _really_ care about duration. I know it is bold, but even so, I think it should be on top. I accidentally thought start was duration at a glance. That's sort of my own fault for not looking carefully, but at the same time, the thing we should make users take away at a glance is the duration.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

As of bug 1165504, only duration is shown -- changing this to readd start/end times as tooltips (I think they'll be way less useful especially once we have marker folding)

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1157916-duration-tooltip.patch

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8607737 [details] [diff] [review]
1157916-duration-tooltip.patch

Review of attachment 8607737 [details] [diff] [review]:
-----------------------------------------------------------------

Possibly add a small test.

::: browser/devtools/shared/timeline/marker-utils.js
@@ +116,2 @@
>      el.classList.add("marker-details-duration");
> +    el.setAttribute("tooltiptext", `${start} - ${end}`);

This looks like a minus. Use `→` maybe?

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1157916-duration-tooltip.patch

This test was way more difficult than one would imagine

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/8803f388005c
remote:   https://hg.mozilla.org/integration/fx-team/rev/10fc07861f4c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/10fc07861f4c

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8607798 [details] [diff] [review]
1157916-duration-tooltip.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19a6b64c5155

Comment 9

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8607798 [details] [diff] [review]
1157916-duration-tooltip.patch

Change approved to skip one train as part of the spring campaign.

Comment 11

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 40.0a2 (2015-06-04), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.8.5.

The sidebar shows the duration for every marker. Hovering over it shows the start and end times, e.g. http://i.imgur.com/pFq2f12.png.