Closed Bug 1157916 Opened 4 years ago Closed 4 years ago

"start" and "end" marker times should be shown in marker details

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(firefox40 verified, firefox41 fixed)

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- verified
firefox41 --- fixed

People

(Reporter: fitzgen, Assigned: jsantell)

References

Details

(Whiteboard: [polish-backlog][difficulty=easy])

Attachments

(1 file, 1 obsolete file)

I don't really care about start/end -- I _really_ care about duration. I know it is bold, but even so, I think it should be on top. I accidentally thought start was duration at a glance. That's sort of my own fault for not looking carefully, but at the same time, the thing we should make users take away at a glance is the duration.
Whiteboard: [devedition-40][difficulty=easy]
Priority: -- → P2
As of bug 1165504, only duration is shown -- changing this to readd start/end times as tooltips (I think they'll be way less useful especially once we have marker folding)
Summary: "Duration" should be above "start" and "end" in the marker details sidebar → "start" and "end" marker times should be shown in marker details
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attached patch 1157916-duration-tooltip.patch (obsolete) — Splinter Review
Attachment #8607737 - Flags: review?(vporof)
Comment on attachment 8607737 [details] [diff] [review]
1157916-duration-tooltip.patch

Review of attachment 8607737 [details] [diff] [review]:
-----------------------------------------------------------------

Possibly add a small test.

::: browser/devtools/shared/timeline/marker-utils.js
@@ +116,2 @@
>      el.classList.add("marker-details-duration");
> +    el.setAttribute("tooltiptext", `${start} - ${end}`);

This looks like a minus. Use `→` maybe?
Attachment #8607737 - Flags: review?(vporof) → review+
This test was way more difficult than one would imagine
Attachment #8607737 - Attachment is obsolete: true
Attachment #8607798 - Flags: review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/8803f388005c
remote:   https://hg.mozilla.org/integration/fx-team/rev/10fc07861f4c
Whiteboard: [devedition-40][difficulty=easy] → [devedition-40][difficulty=easy][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/10fc07861f4c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [devedition-40][difficulty=easy][fixed-in-fx-team] → [devedition-40][difficulty=easy]
Target Milestone: --- → Firefox 41
Flags: qe-verify+
Comment on attachment 8607798 [details] [diff] [review]
1157916-duration-tooltip.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8607798 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8607798 [details] [diff] [review]
1157916-duration-tooltip.patch

Change approved to skip one train as part of the spring campaign.
Attachment #8607798 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-04), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.8.5.

The sidebar shows the duration for every marker. Hovering over it shows the start and end times, e.g. http://i.imgur.com/pFq2f12.png.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Whiteboard: [devedition-40][difficulty=easy] → [polish-backlog][difficulty=easy]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.