Closed
Bug 1157917
Opened 9 years ago
Closed 9 years ago
The binary approval hook should print which changeset is missing ba=
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RyanVM, Assigned: gps)
Details
Attachments
(1 file)
Right now, if you hit the binary approval hook, you get an error like: remote: *** IDL file dom/media/gmp/mozIGeckoMediaPluginService.idl altered in this changeset*** There's no indication of *which* changeset is at fault. Can we make it print the revision as well similar to what the UUID change hook does? Would save some time :)
|
Assignee | |
Comment 1•9 years ago
|
||
mozhghooks: print changeset in prevent_uuid_changes hook (bug 1157917); r?RyanVM This should make the error more actionable.
Attachment #8683322 -
Flags: review?(ryanvm)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8683322 [details] MozReview Request: mozhghooks: print changeset in prevent_uuid_changes hook (bug 1157917); r?RyanVM https://reviewboard.mozilla.org/r/24283/#review22059 Thanks for doing this!
Attachment #8683322 -
Flags: review?(ryanvm) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/8cfe48294a4ba06c361ef546524d0520ca4715bf mozhghooks: print changeset in prevent_uuid_changes hook (bug 1157917); r=RyanVM
|
|
Assignee | |
Comment 4•9 years ago
|
||
Deploying now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•