Closed Bug 1157922 Opened 9 years ago Closed 9 years ago

Hi-res search engine icons for iOS

Categories

(Firefox for iOS :: Browser, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: bnicholson, Assigned: bnicholson)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Opening this in parallel to bug 1156917 so we don't step on each others' toes with the bug status.
Status: NEW → ASSIGNED
Attached file Pull request (obsolete) —
Robin, what do you think?
Attachment #8596852 - Flags: feedback?(randersen)
(In reply to Brian Nicholson (:bnicholson) from comment #1)
> Created attachment 8596852 [details] [review]
> Pull request
> 
> Robin, what do you think?

:bnicholson, the assets I supplied are 60,96,128 — so the @3x is 128 — which now I am assuming may be too large by double on all sizes. can resize to whatever we need. I also like the slight radius that antlam had on his versions.
Attached file Pull request
Attachment #8596852 - Attachment is obsolete: true
Attachment #8596852 - Flags: feedback?(randersen)
Attachment #8596923 - Flags: review?(sarentz)
Comment on attachment 8596923 [details] [review]
Pull request

Few nits in the PR comments to make the code more stable.
Attachment #8596923 - Flags: review?(sarentz) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
tracking-fennec: ? → +
Depends on: 1164963
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: