1157946 - Fix more logspam in DAMP

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Brian Grinstead [:bgrins]]

This appears to happen when the toolbox is closed before _onSourcesAdded is fired in the debugger:

Handler function DebuggerClient.requester request callback threw an exception: TypeError: aResponse.sources is undefined

Comment 1

[Brian Grinstead [:bgrins]]

This can be "easily" reproduced in the damp test suite by following these instructions:

https://wiki.mozilla.org/Buildbot/Talos/Running#Running_locally_-_Source_Code
Then run: talos -n -d --develop --executablePath PATH_TO_FIREFOX --activeTests damp

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: damp-logspam.patch

Comment 3

[Brian Grinstead [:bgrins]]

With this patch applied the crashes seem to change a bit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b49fb151328&exclusion_profile=false

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: damp-spam.patch

Just a quick fix that cleans up the logspam

Comment 5

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2b6ba186707

Comment 6

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/18a5781a6b93

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18a5781a6b93