Fix more logspam in DAMP

RESOLVED FIXED in Firefox 40

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 40
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This appears to happen when the toolbox is closed before _onSourcesAdded is fired in the debugger:

Handler function DebuggerClient.requester request callback threw an exception: TypeError: aResponse.sources is undefined
(Assignee)

Comment 1

4 years ago
This can be "easily" reproduced in the damp test suite by following these instructions:

https://wiki.mozilla.org/Buildbot/Talos/Running#Running_locally_-_Source_Code
Then run: talos -n -d --develop --executablePath PATH_TO_FIREFOX --activeTests damp
(Assignee)

Updated

4 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Depends on: 1153886
(Assignee)

Updated

4 years ago
Blocks: 1158153
(Assignee)

Comment 2

4 years ago
Created attachment 8597522 [details] [diff] [review]
damp-logspam.patch
(Assignee)

Comment 3

4 years ago
With this patch applied the crashes seem to change a bit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b49fb151328&exclusion_profile=false
(Assignee)

Comment 4

4 years ago
Created attachment 8597531 [details] [diff] [review]
damp-spam.patch

Just a quick fix that cleans up the logspam
Attachment #8597522 - Attachment is obsolete: true
Attachment #8597531 - Flags: review?(nfitzgerald)
Attachment #8597531 - Flags: review?(nfitzgerald) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/18a5781a6b93
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/18a5781a6b93
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.