11580 - [code] nsMsgIdentity::getCharPref (and other methods) use m_prefs even if it is null

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[John Bandhauer]

It is painful to bulletproof everything. But...

Components expxosed to JS can be instantiated and have methods called and
attributes twiddled even if their 'normal' custom initilization has not been
run.

This will crash if the following code is run using xpcshell...

var name = "component://netscape/messenger/identity";

try {
    var foo = Components.classes[name].createInstance();
    print(foo);
    print(name);
    for(p in Components.interfaces) {
        try {
            iface = foo.QueryInterface(Components.interfaces[p]);
            if(typeof(iface) == 'undefined')
                continue;
            print("\t"+p);
            for(m in iface) {
                print("\t\t"+m+" = "+typeof(iface[m]));
            }
        } catch(e) {

        }
    }

    foo = null;
    gc();
} catch(e) {
    print("caught+e");
}

Comment 1

[John Bandhauer]

Same story for nsMsgIncomingServer using the above code with:

var name = "component://netscape/messenger/server&type=pop3";

Comment 2

[Alec Flett]

yeah, this is kind of what prefService() was supposed to handle in that other
bug you filed.

Once again, I should just be using NS_WITH_SERVICE..

Comment 3

[Alec Flett]

ok, nsMsgIdentity was actually fixed for M9.

Comment 4

[ppandit]

Changing QA contact to ppandit

Comment 5

[ppandit]

Ran the sample code in xpcshell using a debug build on Windows NT from today
(10/11/99). Since all of the objects were defined, the problem has been
resolved. Confirmed with Alec.

VERIFIED


  D:\mozilla\dist\WIN32_D.OBJ\bin>xpcshell
  nsNativeComponentLoader: autoregistering D:\mozilla\dist\WI
  nts
  nsNativeComponentLoader: autoregistering succeeded
  js> var name = "component://netscape/messenger/identity";
  js>
  js> try {
      var foo = Components.classes[name].createInstance();
      print(foo);
      print(name);
      for(p in Components.interfaces) {
          try {
              iface = foo.QueryInterface(Components.interface
              if(typeof(iface) == 'undefined')
                  continue;
              print("\t"+p);
              for(m in iface) {
                  print("\t\t"+m+" = "+typeof(iface[m]));
              }
          } catch(e) {

          }
      }

      foo = null;
      gc();
  } catch(e) {
      print("caught+e");
  }
  [xpconnect wrapped nsISupports]
  component://netscape/messenger/identity
          nsISupports
                  QueryInterface = function
          nsIMsgIdentity
                  QueryInterface = function
                  key = string
                  identityName = string
                  fullName = object
                  email = object
                  replyTo = object
                  organization = object
                  composeHtml = boolean
                  attachSignature = boolean
                  attachVCard = boolean
                  signature = object
                  vCard = object
                  doFcc = boolean
                  fccFolder = object
                  bccSelf = boolean
                  bccOthers = boolean
                  bccList = object
                  draftFolder = object
                  stationaryFolder = object
                  junkMailFolder = object
                  toString = function
  before 23184, after 8262, break 00000000

Comment 6

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/4153e50f3289
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11580 - Tracks text selection context menu usage (https://github.com/mozilla-mobile/fenix/pull/16968)