The default bug view has changed. See this FAQ.

Support sendMailTo for URN type attendees

RESOLVED FIXED in 4.2

Status

Calendar
Dialogs
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Tracking

Trunk
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Add support for sending e-mail to attendees/organizer with URN-type id at for all occurences of sendMailTo(). Follow up to bug 1156015.
(Assignee)

Comment 1

2 years ago
Created attachment 8597106 [details] [diff] [review]
FollowUpUrnEmailSupport-v1.diff

Patch needs to be applied on top of fix for bug 1156015.
Attachment #8597106 - Flags: review?(philipp)
Comment on attachment 8597106 [details] [diff] [review]
FollowUpUrnEmailSupport-v1.diff

Review of attachment 8597106 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/calendar-task-view.js
@@ +214,5 @@
>      var item = document.getElementById("calendar-task-tree").currentTask;
>      if (item != null) {
> +        let organizer = item.organizer;
> +        let email = cal.getAttendeeEmail(organizer, true);
> +        let emailSubject = calGetString("calendar-event-dialog", "emailSubjectReply", [item.title]);

cal.calGetString()

::: calendar/base/content/dialogs/calendar-event-dialog.js
@@ +3666,5 @@
>   */
>  function sendMailToAttendees(aAttendees) {
> +    let toList = cal.getRecipientList(aAttendees);
> +    let item = saveItem();
> +    let emailSubject = calGetString("calendar-event-dialog", "emailSubjectReply", [item.title]);

cal.calGetString()

::: calendar/base/content/dialogs/calendar-summary-dialog.js
@@ +362,5 @@
> +    let args = window.arguments[0];
> +    let item = args.calendarEvent;
> +    let organizer = item.organizer;
> +    let email = cal.getAttendeeEmail(organizer, true);
> +    let emailSubject = calGetString("calendar-event-dialog", "emailSubjectReply", [item.title]);

cal.calGetString()

::: calendar/base/modules/calUtils.jsm
@@ +341,5 @@
>      /**
> +     * Provides a string to use in email "to" header for given attendees
> +     *
> +     * @param  array   Array of calIAttendee's
> +     * @return string  Valid string to use in to header

@param {Array[calIAttendee]} aAttendee    Attendees the emails should be addressed to
@return {String}                          Valid To-header string of attendees.

Or drop the types and just describe it as you have.

@@ +355,5 @@
> +            if (rEmail.length && toList.length > 0) {
> +                toList += ", ";
> +            }
> +            // Add this recipient id to the list.
> +            toList += rEmail;

Same comment as in the other review about map/filter/reduce.
Attachment #8597106 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8603817 [details] [diff] [review]
FollowUpUrnEmailSupport-v2.diff

Updated patch with comments considered. Needs to be applied on to of the patch for bug 1156015.
Attachment #8597106 - Attachment is obsolete: true
Attachment #8603817 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/comm-central/rev/e9b7b595cf81
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.2

Updated

a year ago
Depends on: 1228438
You need to log in before you can comment on or make changes to this bug.