11581 - No FinalizeInstall() call still completes installation of install script

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 8/9/99 SeaMonkey build

1. From http://jimbob/trigger2.html, trigger http://jimbob/jars/r_nofinalize.jar

Install.StartInstall("No Finalize Test", "/NoFinalize", "1", 0);
f = Install.GetFolder("Communicator");
if (f == null)
   Install.LogComment("ERROR "+EGETFOLDER+": GetFolder\(Communicator\) returned
NULL.");
else
{
   Install.AddSubcomponent( "", jarSrc, f, "");
}

RESULT:
The file gets installed.  There is no node from the Version Registry.  The
Install.log indicates success as well:

---------------------------------------------------------------------------
http://jimbob/jars/r_nofinalize.jar     --     08/10/1999 16:19:03
---------------------------------------------------------------------------

No Finalize Test

** DIAGNOSTIC 0: StartInstall
** DIAGNOSTIC 0: AddSubcomponent(C:\Program Files\moz89\x86rel\smrtupdt.txt)
Finished Installation  08/10/1999 16:19:03

EXPECTED RESULT:
At first I was surprised that the installation took place.  But I'm not sure if
we require the use of Install.FinalizeInstall().  If the same jar is triggered a
second time, the previously installed file is not replaced.  Instead, a file
with "-1" appended to the file name is installed.  I have not checked the
behavior if a directory is installed.  Should we be checking for
FinalizeInstall() before starting the install script?

Comment 1

[Cathleen]

reassign to Dan, setting target milestone to M15 per today's bug meeting.

Comment 2

[Daniel Veditz [:dveditz]]

Reassigning to Sean since he's fixing this.

Comment 3

[Sean Su]

fixed.

Comment 4

[Jimmy Lee]

Build 1999-11-08-09-M11(WIN), 1999-11-08-08-M11(MAC), 1999-11-08-08-M11(LINUX)

We now return -229 (Script Error).

Comment 5

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine