1158122 - Remove all occurrences of the gfxIntRect and nsIntRect typedefs in gfx code, replace them by gfx::IntRect

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicolas Silva [:nical]]

Now that gfxIntRect and nsIntRect are typedefs of gfx::IntRect and not separate classes, we can remove all of their occurrences in graphics code (anything under the gfx/ directory).
This is purely a cosmetic change, perfect for someone who would like to understand the workflow of submitting contributions before tackling a real bug or feature.

grep -r nsIntRect gfx/
grep -r gfxIntRect gfx/

and manually replace them by gfx::IntRect in code that is under the mozilla namespace, IntRect for code under mozilla::gfx or .cpp files with "using namespace mozilla::gfx;" or mozilla::gfx::IntRect for the few headers with no namespaces.

Let's leave out the code outside of gfx/ for now to let each module owner decide if, how and/or when to deal with updating the rect classes/typedefs.

Comment 1

[u538282]

What would be the best for this bug: a patch for the entire correction or several patches, one for each subdirectory of gfx/ for example?

Comment 2

[Nicolas Silva [:nical]]

(In reply to thibaud.backenstrass from comment #1)
> What would be the best for this bug: a patch for the entire correction or
> several patches, one for each subdirectory of gfx/ for example?

Several patches would be best.

Comment 3

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/src/

This patch replaces around 45 of the 386 occurences of nsIntRect, all located in subdirectory gfx/src/. Rebuild completed with no errors.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76becfa04f43

Comment 5

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/ipc

Removes all occurences of nsIntRect in gfx/ipc/
Build successful
Complete patch 8602117

Comment 6

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/gl/

Removes all occurences of nsIntRect in gfx/gl/
Build successful
Complete patches 8602117 & 8602252

Comment 7

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/thebes/

Removes all occurences of nsIntRect in gfx/thebes/
Build successful
Complete patches 8602117, 8602252 & 8602256

Comment 8

[u538282]

Attachment: Proposed patch for 1158122: remove some occurences in subdirectory gfx/layers/

Removes all occurences of nsIntRect in gfx/layers/basic/, gfx/layers/d3d9/, gfx/layers/d3d11 and related files :
 - gfx/layers/D3D11ShareHandleImage.h,
 - gfx/layers/D3D9SurfaceImage.cpp,
 - gfx/layers/D3D9SurfaceImage.h.
Build successful
Complete patches 8602117, 8602252, 8602256 & 8602258

Comment 9

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/layers/composite/

Removes all occurences of nsIntRect in gfx/layers/composite/
Build successful
Complete patches 8602117, 8602252, 8602256, 8602258 & 8602268

Comment 10

[u538282]

Attachment: Proposed patch for 1158122: remove all occurences in subdirectory gfx/layers/client/

Removes all occurences of nsIntRect in gfx/layers/client/
Build successful, but after editing the patch file manually (please verify it carefully, I can do another one if there is a problem!)
Complete patches 8602117, 8602252, 8602256, 8602258, 8602268 & 8602273

Comment 11

[u538282]

Attachment: Proposed patch for 1158122: remove all remaining occurences in subdirectory gfx/layers/

Removes all remaining occurences of nsIntRect in gfx/layers/ (mostly gfx/layers/*.h and gfx/layers/*.cpp files)
Build successful
Complete patches 8602117, 8602252, 8602256, 8602258, 8602268, 8602273 & 8602520

Comment 12

[u538282]

Attachment: Proposed patch for 1158122: remove most occurences in subdirectory gfx/tests/

Removes most occurences of nsIntRect in gfx/tests/
Build successful, but after editing the patch file manually (please verify it carefully, I can do another one if there is a problem!)
Complete patches 8602117, 8602252, 8602256, 8602258, 8602268, 8602273, 8602520 & 8602522

It seems that I cannot change the lines 432 to 439 in https://hg.mozilla.org/integration/mozilla-inbound/file/27bd818ba469/gfx/tests/gtest/TestRect.cpp#l432 without having a build failure, so I didn't modified them.

Comment 13

[u538282]

My 9 patches above removed nearly all occurences of nsIntRect in gfx/ :
  - the typedef in https://hg.mozilla.org/integration/mozilla-inbound/file/27bd818ba469/gfx/src/nsRect.h#l26 has not been removed since it is used in other directories than gfx/,
  - the lines https://hg.mozilla.org/integration/mozilla-inbound/file/27bd818ba469/gfx/tests/gtest/TestRect.cpp#l432 remained unchanged because it seems to cause trouble.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3bc38042efe
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ccef0dba530
https://hg.mozilla.org/integration/mozilla-inbound/rev/0124362f1d0d
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fe012b57499
https://hg.mozilla.org/integration/mozilla-inbound/rev/31f9997fd7b0
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b36252183e6
https://hg.mozilla.org/integration/mozilla-inbound/rev/285ba2b18e50
https://hg.mozilla.org/integration/mozilla-inbound/rev/81b2c07f94ef

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76becfa04f43

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3bc38042efe
https://hg.mozilla.org/mozilla-central/rev/2ccef0dba530
https://hg.mozilla.org/mozilla-central/rev/0124362f1d0d
https://hg.mozilla.org/mozilla-central/rev/8fe012b57499
https://hg.mozilla.org/mozilla-central/rev/31f9997fd7b0
https://hg.mozilla.org/mozilla-central/rev/0b36252183e6
https://hg.mozilla.org/mozilla-central/rev/285ba2b18e50
https://hg.mozilla.org/mozilla-central/rev/81b2c07f94ef

Comment 17

[(Away)]

In the future, if you have more of these renames coming, please advise stability@m.o to be on the lookout, because these patches dramatically change crash signatures.