When there is nothing to push, beta2release_l10n.sh should not fail



4 years ago
4 years ago


(Reporter: sylvestre, Unassigned)


Firefox Tracking Flags

(Not tracked)




4 years ago
This morning, Massimo called the beta2release_l10n.sh script. It stopped working because there was nothing to push for a locale:
"pushing to ssh://hg.mozilla.org/releases/l10n/mozilla-release/ca ...  no changes found "

We should update the script to make sure it continues.
I disagree. There is no (easy way) for the script to distinguish between 'hg push' failure causes. (There were other script issues at the time this bug was filed that may have led to the message.)

The only legitimate case I can think of for there being nothing to push ("no changes found") is if someone committed changes directly to m-r after it was in sync with m-b. That's not our normal workflow, so is worthy of investigation.

The workaround is simple if such a change was intentional: re-run the script. The problem locale will be skipped on 2nd pass (since working directories still exist) as long as the '--mrproper' option is not used.

Note that the long term fix will be to get the locale fix applied normally to the l10n-central repo, then merged forward as normal. That seems an appropriate recovery for a "should never happen" situation.

Please reopen if you feel otherwise. Citing a use case where we'd expect this behavior would help me in understanding the issue further.
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.