In this try build: https://treeherder.mozilla.org/logviewer.html#?job_id=6921689&repo=try I get the unhelpful: WARNING: 'NS_FAILED(aStatus)', file /builds/slave/try-m64-d-00000000000000000000/build/src/dom/workers/ServiceWorkerManager.cpp, line 135 This just says that some error made it to ServiceWorkerManager::Done(), but no indication of where it came from or what it is.
Created attachment 8597356 [details] [diff] [review] Improve ServiceWorkerManager NS_WARNINGS on failure. r=nsm I ran this locally and saw both nsPrintfCString() calls execute correctly. Also, it does not seem too spammy in the few runs I tried.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #8597356 - Flags: review?(nsm.nikhil)
Attachment #8597356 - Flags: review?(nsm.nikhil) → review+
Comment on attachment 8597356 [details] [diff] [review] Improve ServiceWorkerManager NS_WARNINGS on failure. r=nsm >diff --git a/dom/workers/ServiceWorkerManager.cpp b/dom/workers/ServiceWorkerManager.cpp >+ NS_WARNING(nsPrintfCString("ServiceWorkerJob failed with error: %s\n", >+ errorName.get()).get()); Nit: the second line here is mis-indented. It's an argument for the "nsPrintfCString(...)" call, so it should be indented to just after "nsPrintfCString(". (If you like, you could address this with a trivial "DONTBUILD, whitespace-only" followup)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.