1158218 - ServiceWorkerManager could WARN in more failure cases

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In this try build:

  https://treeherder.mozilla.org/logviewer.html#?job_id=6921689&repo=try

I get the unhelpful:

  WARNING: 'NS_FAILED(aStatus)', file /builds/slave/try-m64-d-00000000000000000000/build/src/dom/workers/ServiceWorkerManager.cpp, line 135

This just says that some error made it to ServiceWorkerManager::Done(), but no indication of where it came from or what it is.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Improve ServiceWorkerManager NS_WARNINGS on failure. r=nsm

I ran this locally and saw both nsPrintfCString() calls execute correctly.  Also, it does not seem too spammy in the few runs I tried.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2be077bef26

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/98b0e8e0c180

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8597356 [details] [diff] [review]
Improve ServiceWorkerManager NS_WARNINGS on failure. r=nsm

>diff --git a/dom/workers/ServiceWorkerManager.cpp b/dom/workers/ServiceWorkerManager.cpp
>+    NS_WARNING(nsPrintfCString("ServiceWorkerJob failed with error: %s\n",
>+               errorName.get()).get());

Nit: the second line here is mis-indented. It's an argument for the "nsPrintfCString(...)" call, so it should be indented to just after "nsPrintfCString(".

(If you like, you could address this with a trivial "DONTBUILD, whitespace-only" followup)

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Thanks.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c0425d3c88

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98b0e8e0c180
https://hg.mozilla.org/mozilla-central/rev/e6c0425d3c88