1158220 - Add more unit tests to the router specs.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Bug 1155611 added a couple of them, but it seems we're not testing all the paths. I think I can help by adding some new tests.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

Still WIP

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8597346 [details] [review]
PR

Hey guys,

Here are some new tests for the router in serviceworkerware. I currently have 2 issues with them:
 * passing an object with onFetch() can't be tested because we bind it so add is not called with the exact onFetch() method we passed. Do you guys have any idea on how to help to get it tested?
 * router.all() will match every method, including the ones which are not valid.

Tell me guys what you think!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8597346 [details] [review]
PR

Just commented in github, will let Salva come with the r?

Thanks a lot for the pr, how is your experience with the environment set?

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8597346 [details] [review]
PR

I corrected the points you raised. I discussed on IRC with Francisco about how to fix the bug about router.match("invalidMethod"), which returned all the middlewares. He agrees on throwing an error if the method is invalid in each case.

I factorized this behavior into _sanitizeMethod(). I moved the 'lowercase', 'trim' and 'error' tests to that method, and I check that add() and match() call it correctly.

Resetting the flag for another review.

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8597346 [details] [review]
PR

master: arcturus/serviceworkerware#2c2b60a688157575f4c70843aada88667d069f3d