Closed Bug 1158232 Opened 5 years ago Closed 5 years ago

[Customizer] Replace 'Events' tab with 'Script' tab to allow direct access to edit the generated add-on

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

In order to be as flexible as possible for "V1", we should allow the user to directly edit the generated add-on script.
Bulk update to set the correct component and whiteboard.
Component: Gaia → Gaia::Customizer
Whiteboard: [spark]
Attached file pull-request (master)
Attachment #8598817 - Flags: review?(drs)
Assignee: nobody → jdarcangelo
Priority: -- → P1
Comment on attachment 8598817 [details] [review]
pull-request (master)

I left a couple of comments, one of which requires some discussion, so I'm not changing the review flag yet. But this generally looks good.
Comment on attachment 8598817 [details] [review]
pull-request (master)

Looks good. Two points:

* I left a comment about filing a bug for the CSS variable workaround, and including that number in the comment.
* Please file a followup for doing some very simple validation on source passed into the "Script" section.
Attachment #8598817 - Flags: review?(drs) → review+
Landed on master:

https://github.com/fxos/customizer/commit/44f6c9709a09774ff9831e92a90fda62092ec361
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Follow-up for adding JavaScript code validation: Bug 1159454
You need to log in before you can comment on or make changes to this bug.