1158257 - Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Right now only the shell calls JS::dbg::SetDebuggerMallocSizeOf, meaning that we can't use JS::ubi::Node::size meaningfully outside of shell builds.

I think CycleCollectedJSRuntime is the right place.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8597416 [details] [diff] [review]
Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf

Review of attachment 8597416 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, tests!

::: js/src/vm/DebuggerMemory.cpp
@@ +337,5 @@
>  /* Debugger.Memory.prototype.takeCensus */
>  
>  void
>  JS::dbg::SetDebuggerMallocSizeOf(JSRuntime* rt, mozilla::MallocSizeOf mallocSizeOf) {
> +    printf("FITZGEN: inside JS::dbg::SetDebuggerMallocSizeOf\n");

remove this

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> @@ +337,5 @@
> >  /* Debugger.Memory.prototype.takeCensus */
> >  
> >  void
> >  JS::dbg::SetDebuggerMallocSizeOf(JSRuntime* rt, mozilla::MallocSizeOf mallocSizeOf) {
> > +    printf("FITZGEN: inside JS::dbg::SetDebuggerMallocSizeOf\n");
> 
> remove this

>_< sorry

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbb558c6c52

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/600207b62020

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/600207b62020