1158284 - gfxPlatform::InSafeMode, some pref cleanup, lazier evaluation for acceleration

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Just a place to park all these small changes.  May as well have a simple utility to check if we're in safe mode, this will not change during app lifetime.  Use gfxPrefs methods in a few places where we don't and only evaluate some of the things needed to decide if we should accelerate or not once we actually need those values.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Utility function for safe mode and pref cleanup. r=botond

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8597391 [details] [diff] [review]
Utility function for safe mode and pref cleanup. r=botond

Review of attachment 8597391 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment.

::: gfx/thebes/gfxPlatform.cpp
@@ +1768,5 @@
> +  if (!sSafeModeInitialized) {
> +    nsCOMPtr<nsIXULRuntime> xr = do_GetService("@mozilla.org/xre/runtime;1");
> +    if (xr) {
> +      xr->GetInSafeMode(&sInSafeMode);
> +    }

Set sSafeModeInitialized to true.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Botond Ballo [:botond] from comment #2)
> Comment on attachment 8597391 [details] [diff] [review]
> Utility function for safe mode and pref cleanup. r=botond
> 
> Review of attachment 8597391 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ with comment.
> 
> ::: gfx/thebes/gfxPlatform.cpp
> @@ +1768,5 @@
> > +  if (!sSafeModeInitialized) {
> > +    nsCOMPtr<nsIXULRuntime> xr = do_GetService("@mozilla.org/xre/runtime;1");
> > +    if (xr) {
> > +      xr->GetInSafeMode(&sInSafeMode);
> > +    }
> 
> Set sSafeModeInitialized to true.

Good catch, thanks.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Utility function for safe mode and pref cleanup. Carry r=botond

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a826d2e8747a

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Try looks green beyond the intermittents.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd54590ebfbd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dd54590ebfbd