Closed Bug 1158284 Opened 10 years ago Closed 10 years ago

gfxPlatform::InSafeMode, some pref cleanup, lazier evaluation for acceleration

Categories

(Core :: Graphics, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: milan, Assigned: milan)

Details

Attachments

(1 file, 1 obsolete file)

Just a place to park all these small changes. May as well have a simple utility to check if we're in safe mode, this will not change during app lifetime. Use gfxPrefs methods in a few places where we don't and only evaluate some of the things needed to decide if we should accelerate or not once we actually need those values.
Assignee: nobody → milan
Comment on attachment 8597391 [details] [diff] [review] Utility function for safe mode and pref cleanup. r=botond Review of attachment 8597391 [details] [diff] [review]: ----------------------------------------------------------------- r+ with comment. ::: gfx/thebes/gfxPlatform.cpp @@ +1768,5 @@ > + if (!sSafeModeInitialized) { > + nsCOMPtr<nsIXULRuntime> xr = do_GetService("@mozilla.org/xre/runtime;1"); > + if (xr) { > + xr->GetInSafeMode(&sInSafeMode); > + } Set sSafeModeInitialized to true.
Attachment #8597391 - Flags: review?(botond) → review+
(In reply to Botond Ballo [:botond] from comment #2) > Comment on attachment 8597391 [details] [diff] [review] > Utility function for safe mode and pref cleanup. r=botond > > Review of attachment 8597391 [details] [diff] [review]: > ----------------------------------------------------------------- > > r+ with comment. > > ::: gfx/thebes/gfxPlatform.cpp > @@ +1768,5 @@ > > + if (!sSafeModeInitialized) { > > + nsCOMPtr<nsIXULRuntime> xr = do_GetService("@mozilla.org/xre/runtime;1"); > > + if (xr) { > > + xr->GetInSafeMode(&sInSafeMode); > > + } > > Set sSafeModeInitialized to true. Good catch, thanks.
Try looks green beyond the intermittents.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: