1158302 - Increase the Font Size of Reader's H1 and H2 Headers

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Michael Maslaney [:mmaslaney] ([e-mail])]

Increase the following Font-sizes:

H1
From 1.3em to 1.6em

H2
From 1.1em to 1.2em

Comment 1

[Blake Winton (:bwinton) (:☕️)]

H1 and H2 elements: https://www.dropbox.com/s/kej7l8gtsljeuv6/Screenshot%202015-04-24%2014.41.54.png?dl=0
How do you feel about the line-height, Michael?

Comment 2

[Michael Maslaney [:mmaslaney] ([e-mail])]

\o/ +1

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Attachment: The first cut at the patch.

Comment 4

[Marco Mucci [:MarcoM]]

Hi Blake, can you provide a point value.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Review of attachment 8597528 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Approval Request Comment
[Feature/regressing bug #]: readermode
[User impact if declined]: Slightly harder to read headers.
[Describe test coverage new/current, TreeHerder]: Manual.
[Risks and why]: Low risk, CSS-only change.
[String/UUID change made/needed]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f6ee3076f6ab

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6ee3076f6ab

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Approving for uplift to aurora and to beta (from discussion with Sylvestre). 

We want this to be in 38.0.5, but not in 38.0, since Reader Mode is disabled for 38.0 on Desktop.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

As mentioned before, the Target Milestone tracks landing on m-c. Please make sure it's set correctly or it'll interfere with uplifts.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5c932575909e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3058929d4335

Comment 13

[Ashickur Rahman]

Towkir, please mention in which build the fix works for you :) .

Comment 14

[[:Towkir] Ahmed]

fixed version 38.0.5 | fixed Build  :  20150521175336

application basic of the fixed version is here http://prntscr.com/7qld12

h1 has been made 1.6 em as per mentioned on description or comment 0. have a look at http://prntscr.com/7qldnc

the same goes for h2.  check  http://prntscr.com/7qldva

extremely sorry for not mentioning informations while changing status.
Thanks :)