Closed Bug 1158302 Opened 5 years ago Closed 4 years ago

Increase the Font Size of Reader's H1 and H2 Headers

Categories

(Firefox :: General, defect)

38 Branch
defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox38 --- wontfix
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: mmaslaney, Assigned: bwinton)

References

Details

Attachments

(1 file)

Increase the following Font-sizes:

H1
From 1.3em to 1.6em

H2
From 1.1em to 1.2em
H1 and H2 elements: https://www.dropbox.com/s/kej7l8gtsljeuv6/Screenshot%202015-04-24%2014.41.54.png?dl=0
How do you feel about the line-height, Michael?
Flags: needinfo?(mmaslaney)
\o/ +1
Flags: needinfo?(mmaslaney)
Attachment #8597528 - Flags: ui-review?(mmaslaney)
Attachment #8597528 - Flags: review?(gijskruitbosch+bugs)
Attachment #8597528 - Flags: ui-review?(mmaslaney) → ui-review+
Hi Blake, can you provide a point value.
Status: NEW → ASSIGNED
Iteration: --- → 40.2 - 27 Apr
Flags: qe-verify-
Flags: needinfo?(bwinton)
Flags: firefox-backlog+
Points: --- → 1
Flags: needinfo?(bwinton)
Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Review of attachment 8597528 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8597528 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Approval Request Comment
[Feature/regressing bug #]: readermode
[User impact if declined]: Slightly harder to read headers.
[Describe test coverage new/current, TreeHerder]: Manual.
[Risks and why]: Low risk, CSS-only change.
[String/UUID change made/needed]: None.
Attachment #8597528 - Flags: approval-mozilla-beta?
Attachment #8597528 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f6ee3076f6ab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Comment on attachment 8597528 [details] [diff] [review]
The first cut at the patch.

Approving for uplift to aurora and to beta (from discussion with Sylvestre). 

We want this to be in 38.0.5, but not in 38.0, since Reader Mode is disabled for 38.0 on Desktop.
Attachment #8597528 - Flags: approval-mozilla-beta?
Attachment #8597528 - Flags: approval-mozilla-beta+
Attachment #8597528 - Flags: approval-mozilla-aurora?
Attachment #8597528 - Flags: approval-mozilla-aurora+
As mentioned before, the Target Milestone tracks landing on m-c. Please make sure it's set correctly or it'll interfere with uplifts.
Target Milestone: Firefox 38 → Firefox 40
Status: RESOLVED → VERIFIED
Towkir, please mention in which build the fix works for you :) .
Status: VERIFIED → RESOLVED
Closed: 4 years ago4 years ago
Flags: needinfo?(towkir17)
fixed version 38.0.5 | fixed Build  :  20150521175336

application basic of the fixed version is here http://prntscr.com/7qld12

h1 has been made 1.6 em as per mentioned on description or comment 0. have a look at http://prntscr.com/7qldnc

the same goes for h2.  check  http://prntscr.com/7qldva

extremely sorry for not mentioning informations while changing status.
Thanks :)
Flags: needinfo?(towkir17)
You need to log in before you can comment on or make changes to this bug.