1158351 - Add unit tests for WifiHelper.isValidInput method

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sam Foster [:sfoster] (he/him)]

We have no unit test coverage for WifiHelper's isValidInput method, which validates a password for the different network security types. Just checking the return value with some sample good and bad inputs would help make this slightly less opaque

Comment 1

[Aron Barreira Bordin]

Hi Sam,

This bug looks to be simple. Can I be assigned to work with it?

Comment 2

[Sam Foster [:sfoster] (he/him)]

(In reply to Aron Barreira Bordin from comment #1)
> Hi Sam,
> 
> This bug looks to be simple. Can I be assigned to work with it?

Go ahead Aron. I've assigned myself as mentor but we'll need to find another reviewer - perhaps :arthurcc or :ehung.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

Comment 4

[Aron Barreira Bordin]

Hi Sam. Do you know who can review my PR?

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to Aron Barreira Bordin from comment #4)
> Hi Sam. Do you know who can review my PR?

Lets try [e-mail]? Left a couple nits in the PR you could address in the meantime.

Comment 6

[Evelyn Hung]

Comment on attachment 8600692 [details] [review]
[gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

redirect to Arthur, he should be more familiar with wifi helper than me.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8600692 [details] [review]
[gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

EJ, could you help review this patch? Thanks.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8600692 [details] [review]
[gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

Thanks Aron, I left some comments there and please check them ! Feel free to set r? on me when you have time, thanks ;)

Comment 9

[Aron Barreira Bordin]

Hi EJ,

I'm a little confused about a note in my PR. I left you a message there, please, can you take a look?

Thx

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks for asking Aron, I did leave more details in GitHub and please go check it when you have time ! I think this patch is almost done and after related comments are addressed, we are ready to let it merged :)

Thanks Aron !

Comment 11

[Aron Barreira Bordin]

Comment on attachment 8600692 [details] [review]
[gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

Hi!

Please, when possible, take a look in my new patch.

Thx!

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8600692 [details] [review]
[gaia] aron-bordin:wifi_helper_is_valid_input_tests > mozilla-b2g:master

Thanks for the efforts, Aron ! r++

Comment 13

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Moved to Gaia:Settings to make sure Autoloader works.

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b23e03da9251fc98737a24280bf717ec9c52a8e4