Clean up ObjectGroup marking

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Uses the same basic layout as eagerlyMarkChildren, but instead calls it lazilyMarkChildren as it is dispatched lazily via the mark stack instead of eagerly/immediately.
Attachment #8597465 - Flags: review?(sphink)
Comment on attachment 8597465 [details] [diff] [review]
10.8_clean_up_objectgroup_marking-v0.diff

Review of attachment 8597465 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a huge fan of the name, but I don't have a clearly better option, so r=me as-is. Names I considered:

 processChildren (to match processMarkStackOther)
 markChildren
 deferredMarkChildren

To me, "lazy" means deferred and on-demand, which isn't quite what's going on here. It's deferred, but it's happening because it's the next thing to process from the mark stack, not because it's directly needed by something else (as "lazy" would imply).

But like I said, your name is ok with me.
Attachment #8597465 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/9ebb49787cc1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.