Closed
Bug 1158357
Opened 9 years ago
Closed 9 years ago
Inline processMarkStackOther
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
3.29 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Splitting out the less common cases only obscures the fact that this a dispatch loop. IMHO, making this a flat switch statement is much clearer
Attachment #8597468 -
Flags: review?(jcoppeard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8597468 [details] [diff] [review] 11_rm_process_mark_stack_other-v0.diff Review of attachment 8597468 [details] [diff] [review]: ----------------------------------------------------------------- Yes, that's definitely clearer.
Attachment #8597468 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=995e2defcdb7
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/250eb7785cf7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•