Closed
Bug 1158506
Opened 9 years ago
Closed 9 years ago
[rule view] Filter styles should handle escape keycode correctly
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
Details
Attachments
(1 file)
16.51 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Pressing VK_ESCAPE keycode in the filter styles searchbox should clear the searchbox and not pop up the console unless the searchbox is empty.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gabriel.luong
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77ca9190e0e6
Attachment #8600741 -
Flags: review?(bgrinstead)
Comment 2•9 years ago
|
||
Comment on attachment 8600741 [details] [diff] [review] 1158506.patch [1.0] Review of attachment 8600741 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8600741 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d0e7f60dafaf
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d0e7f60dafaf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•