Closed
Bug 1158537
Opened 11 years ago
Closed 11 years ago
Remove unneeded FileImplTemporaryFileBlob::{mLength,mContentType} members
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.84 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
The FileImplBase base class has protected mLength and mContentType
members that this class can use. These are currently just masking those
base members.
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8597639 -
Flags: review?(amarchesini)
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ehsan
Blocks: shadow-field
Comment 2•11 years ago
|
||
Comment on attachment 8597639 [details] [diff] [review]
Remove unneeded FileImplTemporaryFileBlob::{mLength,mContentType} members
Review of attachment 8597639 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/File.h
@@ +611,2 @@
> , mStartPos(aStart)
> + , mFileDescOwner(aOther->mFileDescOwner) {}
can you put {} in a new line?
Attachment #8597639 -
Flags: review?(amarchesini) → review+
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•