Closed Bug 1158537 Opened 6 years ago Closed 6 years ago

Remove unneeded FileImplTemporaryFileBlob::{mLength,mContentType} members

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The FileImplBase base class has protected mLength and mContentType
members that this class can use.  These are currently just masking those
base members.
Assignee: nobody → ehsan
Blocks: shadow-field
Comment on attachment 8597639 [details] [diff] [review]
Remove unneeded FileImplTemporaryFileBlob::{mLength,mContentType} members

Review of attachment 8597639 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/File.h
@@ +611,2 @@
>      , mStartPos(aStart)
> +    , mFileDescOwner(aOther->mFileDescOwner) {}

can you put {} in a new line?
Attachment #8597639 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/e8e9d876c016
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.