Closed
Bug 1158543
Opened 9 years ago
Closed 9 years ago
Remove SpdyConnectTransaction::mRequestHead and make the base class mRequestHead protected
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.00 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
There is no need to have two separate variables for the same thing in the same object.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: shadow-field
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8597644 -
Flags: review?(mcmanus)
Comment 2•9 years ago
|
||
Comment on attachment 8597644 [details] [diff] [review] Remove SpdyConnectTransaction::mRequestHead and make the base class mRequestHead protected Review of attachment 8597644 [details] [diff] [review]: ----------------------------------------------------------------- new compiler warning?
Attachment #8597644 -
Flags: review?(mcmanus) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Patrick McManus [:mcmanus] from comment #2) > new compiler warning? Yeah. I have implemented a new clang warning called -Wshadow-field (that has not landed in clang yet) which warns about derived classes declaring members which shadow base class members. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2015-April/042514.html>
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1da50757074
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•