Closed
Bug 1158547
Opened 9 years ago
Closed 9 years ago
Useless declaration in Parser.cpp
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: rnath, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1286186])
Attachments
(2 files)
1.06 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
1.12 KB,
patch
|
Details | Diff | Splinter Review |
In https://dxr.mozilla.org/mozilla-central/source/js/src/frontend/Parser.cpp?from=parser.cpp#4784 forStmt.type = STMT_FOR_OF_LOOP; is useless as override the line after.
Reporter | ||
Comment 1•9 years ago
|
||
Ryan, here it is if you want a good first bug (super easy)
Flags: needinfo?(nathmatics)
Assignee | ||
Comment 2•9 years ago
|
||
This patch removes the useless declaration.
Flags: needinfo?(nathmatics)
Attachment #8597668 -
Flags: review?(sledru)
Reporter | ||
Comment 3•9 years ago
|
||
Ryan, I am not the owner of this code. You should find out who is maintaining it (an easy way is to look at the history of file).
Assignee: nobody → nathmatics
Reporter | ||
Updated•9 years ago
|
Attachment #8597668 -
Flags: review?(sledru)
Assignee | ||
Updated•9 years ago
|
Attachment #8597668 -
Flags: review?(jorendorff)
Comment 4•9 years ago
|
||
Comment on attachment 8597668 [details] [diff] [review] rev1 - removal of useless declaration Review of attachment 8597668 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! (embarrassing)
Attachment #8597668 -
Flags: review?(jorendorff) → review+
Comment 5•9 years ago
|
||
You probably want to add "checkin-needed" to get someone to check this patch in. But first, you need to add a commit message to your patch. See https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F for how to do that, and see https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment for tips on a good commit message.
Flags: needinfo?(nathmatics)
Comment 6•9 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #5) > You probably want to add "checkin-needed" to get someone to check this patch > in. (Specifically: once you've reposted the patch with a good commit message, you'll want to add "checkin-needed" to the "Keywords" field at the top of this bug.) (Normally, the Tree sheriffs require that patches receive a TryServer* test before using "checkin-needed"; however, in this case, I'll assert that this is unnecessary, because the patch clearly has no effect on behavior.) * https://wiki.mozilla.org/ReleaseEngineering/TryServer#Try_Server
Assignee | ||
Comment 7•9 years ago
|
||
This is a final patch for this bug. I need someone to checkin.
Flags: needinfo?(nathmatics)
Attachment #8598842 -
Flags: review?(jorendorff)
Assignee | ||
Updated•9 years ago
|
Keywords: coverity → checkin-needed
Comment 8•9 years ago
|
||
Thanks! For future reference: - when adding keywords, please don't remove existing keywords. (Just add your new ones, after the existing ones). - You should include "r=[reviewer]" (r=jorendorff in this case) at the end of your commit message. (though whoever lands the patch can add that in this case.) - No need to re-request review if you've already received r+ (and you're just reposting with a trivial tweak like a commit message addition).
Keywords: coverity
Updated•9 years ago
|
Attachment #8598842 -
Attachment description: Final patch for removal of useless declaration in Parser.cpp → patch for checkin (now with commit message)
Attachment #8598842 -
Flags: review?(jorendorff)
Assignee | ||
Comment 9•9 years ago
|
||
Daniel, thanks for those suggestions. I will keep them in mind for future patches. Many thanks!
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/86f56b03114e
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86f56b03114e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Reporter | ||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•