Closed Bug 1158547 Opened 5 years ago Closed 5 years ago
Useless declaration in Parser
In https://dxr.mozilla.org/mozilla-central/source/js/src/frontend/Parser.cpp?from=parser.cpp#4784 forStmt.type = STMT_FOR_OF_LOOP; is useless as override the line after.
Ryan, here it is if you want a good first bug (super easy)
This patch removes the useless declaration.
Ryan, I am not the owner of this code. You should find out who is maintaining it (an easy way is to look at the history of file).
Assignee: nobody → nathmatics
Comment on attachment 8597668 [details] [diff] [review] rev1 - removal of useless declaration Review of attachment 8597668 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! (embarrassing)
Attachment #8597668 - Flags: review?(jorendorff) → review+
You probably want to add "checkin-needed" to get someone to check this patch in. But first, you need to add a commit message to your patch. See https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F for how to do that, and see https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment for tips on a good commit message.
(In reply to Daniel Holbert [:dholbert] from comment #5) > You probably want to add "checkin-needed" to get someone to check this patch > in. (Specifically: once you've reposted the patch with a good commit message, you'll want to add "checkin-needed" to the "Keywords" field at the top of this bug.) (Normally, the Tree sheriffs require that patches receive a TryServer* test before using "checkin-needed"; however, in this case, I'll assert that this is unnecessary, because the patch clearly has no effect on behavior.) * https://wiki.mozilla.org/ReleaseEngineering/TryServer#Try_Server
This is a final patch for this bug. I need someone to checkin.
Attachment #8598842 - Flags: review?(jorendorff)
Thanks! For future reference: - when adding keywords, please don't remove existing keywords. (Just add your new ones, after the existing ones). - You should include "r=[reviewer]" (r=jorendorff in this case) at the end of your commit message. (though whoever lands the patch can add that in this case.) - No need to re-request review if you've already received r+ (and you're just reposting with a trivial tweak like a commit message addition).
Daniel, thanks for those suggestions. I will keep them in mind for future patches. Many thanks!
You need to log in before you can comment on or make changes to this bug.