115858 - Cannot remove a background image

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Jean-Francois Ducarroz]

Using either a composer page or a message compose window:

1)go to menu Format/Page Colors and Background
2)select a image file for the background
3)close the dialog by pressing OK
==> the background image appears

4)go to menu Format/Page Colors and Background
5)delete the background image url
6)close the dialog by pressing OK
==> the background image still there!

expextec result: No more background image

Comment 1

[Jean-Francois Ducarroz]

nominating nsbeta1, the user should be able to remove a background image.

Comment 2

[Kathleen :Brade]

Is the image *really* there or does it appear to be there?
(If you save and reopen, is it still there?)

This sounds like a duplicate bug of a bug on hyatt's(?) plate.

Comment 3

[Jean-Francois Ducarroz]

If I save and then reopen the page, the background image is gone. This problem
hurt a lot message compose when we use a recycled window.

Comment 4

[Charles Manske]

This is not a Composer problem. The "background" attribute value is removed 
correctly in both Composer and Message Composer, but in mail, the window is not
being redisplayed (it is in Composer).
So I guess this is a layout problem?
cc'ing glazman; I think he knows something about this code.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Would you believe it if I suspect yet another BodyFixupRule side effect ?...
To show it in Composer : give a gif bg, and then remove the gif bg, the bg
is still here, switch to source view and then back to normal, the bg is gone.

Given the number of issues we have with it, the least we can say is that
this code is not clean, or more precisely, not complete.

Comment 6

[Charles Manske]

Yes, that is exactly what I suspected! Daniel: can you take this bug? (Kin won't
be around for next couple of weeks.)

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

me is wondering is this bug is not a dup of bug 96264. Just for the record,
I have attached a patch to 96264 and am waiting for hyatt's review. He is
probably away from Xmas. Charley, can you please try fix for 96264 and see if it
solves the current bug ? Thanks.

Comment 8

[Charles Manske]

I tried the patch to bug 96264, but unfortunately it doesn't seem to fix this
problem. With that patch, there were asserts and crashes when using messenger
Composer (see bug 96264 for details.)

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fixed by checkin of bug 116161 at 2002-01-07 15:45/46 PST.

Comment 10

[Jean-Francois Ducarroz]

I am still not able to remove a background image using a MacOS X debug build
from last night around 6pm

Comment 11

[sujay]

headsup Tucson.

Comment 12

[Kathleen :Brade]

Is this problem now only on OSX or is it on all platforms?  Is it still a problem?
I think dbaron actually did fix this (the OSX problem was unrelated).

Comment 13

[michael wendell]

Yes, this only appears to be happening on OSX.  I don't see a way to delete the 
background through the GUI, and if you try to delete the background image from 
advanced properties or HTML source, it comes right back.

This works fine on Win 98 and Mac OS9 both using the 01-29 trunk builds.

Switching the Platform and OS to Mac / OSX.

Comment 14

[Kevin McCluskey (gone)]

EDITORBASE

Comment 15

[Kevin McCluskey (gone)]

Looks like the bug is in the UI. The "page colors and background" dialog box is
different than what is displayed on WINNT. The text box used to enter the
background image is not present on OSX. 

If you click on the advanced edit button and try to remove the background
attribute it doesn't really remove the background attribute because the next
time you bring up the advanced edit dialog box from the "page colors and
background" dialog box the attribute is still there.

Reassigning back to cmanske.

Comment 16

[Charles Manske]

I find it hard to believe that the "page colors and background" could be different
on OSX! Could you please show a screen shot? This is XP JS code launching a 
XUL dialog!
Simon what do you see on you OSX machine?

Comment 17

[Charles Manske]

Attachment: Fix for problems in Composer UI

Note that using SetTextboxFocus() is necessary to fix focus racing problem 
(bug 125346).

Comment 18

[[e-mail]]

Comment on attachment 70084 [details] [diff] [review]
Fix for problems in Composer UI

r=[e-mail]

Although, instead of
  var innerURL = gBackgroundImage.match( /url\((.*)\)/ ) ;
  if (innerURL)

I would have preferred
  if (/url\((.*)\)/.test(gBackgroundImage))

Comment 19

[Joe Hewitt (gone)]

Comment on attachment 70084 [details] [diff] [review]
Fix for problems in Composer UI

sr=hewitt

Comment 20

[Charles Manske]

checked in

Comment 21

[michael wendell]

Verified.  The page title and background screen is the same as in OS9 and Win, 
and you are now able to delete the background image.