Closed Bug 1158616 Opened 9 years ago Closed 2 years ago

Attach metadata to synchronous reflow markers about which property get/set or method call triggered the synchronous reflow

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: fitzgen, Unassigned)

References

Details

(Whiteboard: [devtools-platform])

I'm debugging a performance issue that boils down to a synchronous reflow caused by jQuery.event.fix. I can see which line the synchronous reflow was triggered on, but unfortunately, that doesn't give me as much as I'd hoped:

> i = copy.length;
> while ( i-- ) {
>   prop = copy[ i ];
>   event[ prop ] = originalEvent[ prop ]; // <---- this line
> }

It would be really nice if we just had something like

  Cause: Node.prototype.[get clientHeight]

As it is now, the tool gives me no idea whether it is a getter on originalEvent or a setter on event, nor which property.
FWIW, copy is this set of properties:

altKey, bubbles, cancelable, ctrlKey, currentTarget, eventPhase, metaKey, relatedTarget, shiftKey, target, timeStamp, view, which, button, buttons, clientX, clientY, offsetX, offsetY, pageX, pageY, screenX, screenY, toElement
Summary: Attach metadata to synchronous reflow markers about which property get/set or method call triggered the synchronous reflow → [marker] Reflow: Attach metadata to synchronous reflow markers about which property get/set or method call triggered the synchronous reflow
Whiteboard: [devtools-platform]
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
Summary: [marker] Reflow: Attach metadata to synchronous reflow markers about which property get/set or method call triggered the synchronous reflow → Attach metadata to synchronous reflow markers about which property get/set or method call triggered the synchronous reflow
Product: Firefox → DevTools
Severity: normal → S3

This report is related to the old DevTools Profiler.
The Performance panel now points to the new Firefox profiler available at profiler.firefox.com
Closing as Invalid bug

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.