Closed Bug 1158645 Opened 9 years ago Closed 9 years ago

Reported FPS average seems really wrong

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: fitzgen, Assigned: jsantell)

Details

(Whiteboard: [polish-backlog])

Attachments

(2 files, 1 obsolete file)

Definitely felt more janky than 45fps and the graph implies that too.
Summary: reported FPS average seems realy wrong → Reported FPS average seems really wrong
Whiteboard: [devedition-40]
Depends on: 1146237
While I thought this was from extra values being in the future (resulting in long durations of 0 fps, as the docshell jumped into the future), which may contribute, we also calculate the mean by traditional sumOfValues/noOfValues, and due to how FPS is recorded, means we'll have many more values for a higher framerate, than we will for lower.

ex: If we have 10 values within one second for 60fps, and 1 value within one second for 0 fps, our average is 54fps, even though half the time was spent in 60fps and the other half was 0fps.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attached patch 1158645-fps.patch (obsolete) — Splinter Review
So this calculates frames over duration, rather than what we had before.

Here's a screenshot of the two methods; the left number in the console is with this patch, the right one before: http://i.imgur.com/mRZa4kS.png
Attachment #8599517 - Flags: review?(vporof)
Comment on attachment 8599517 [details] [diff] [review]
1158645-fps.patch

Review of attachment 8599517 [details] [diff] [review]:
-----------------------------------------------------------------

Much better! I'm ashamed of the old approach.

Doesn't this break any tests? If not, we need a test.
Attachment #8599517 - Flags: review?(vporof) → review+
Added tests
Attachment #8599517 - Attachment is obsolete: true
Attachment #8599562 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/1b3bee7ca060
No longer depends on: 1146237
Whiteboard: [devedition-40] → [fixed-in-fx-team][devedition-40]
https://hg.mozilla.org/mozilla-central/rev/1b3bee7ca060
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-40] → [devedition-40]
Target Milestone: --- → Firefox 40
Whiteboard: [devedition-40] → [polish-backlog]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.