1158652 - RelMan can't start beta's on pulled from m-r

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Hal Wine [:hwine] use NI!]

If there are any localization changes, a fresh merge of content from the l10n m-b repos to m-r repos are needed. There's an existing script for this [1], but relman doesn't have the chops to run it.

Further, the script [1] is relies on the no-longer-valid assumption that there are no 'fennec only' locales. If there is a change in such a locale, the script will not correct the problem.

[1] http://hg.mozilla.org/build/braindump/file/default/releases-related/beta2release_l10n.sh

Comment 1

[Hal Wine [:hwine] use NI!]

meh - I forgot I had this bug when I hacked on the script - already checked in as 
  https://hg.mozilla.org/build/braindump/rev/f08fe13d36d7

Will get code review on any changes from here.

Comment 3

[Hal Wine [:hwine] use NI!]

Attachment: output of sledru's run

Unexpected output from :sledru which failed to merge everything appropriately for 38.0rc1.

Anomalies in output include:
 - multiple references to some locales as "needed merging" (e.g. es-MX)
 - no attempt to pull es-MX
 - some locales worked fine.

Comment 4

[Hal Wine [:hwine] use NI!]

Explanation for all oddities in comment 3 is likely that state is not purged between runs. Likely many (failing) runs were done before the last successful one, leading to the repeats.

There was also in the code a silent skip if a prior locale directory existed. This made sense in the original context of the script, but not the new usage by release mangers. Adding a flag to allow cleanup.

Comment 5

[Hal Wine [:hwine] use NI!]

Attachment: Be less silent & add cleanup option

Additional changes to make script work better for relman's needs. See diff for details

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8600727 [details] [diff] [review]
Be less silent & add cleanup option

Review of attachment 8600727 [details] [diff] [review]:
-----------------------------------------------------------------

::: releases-related/beta2release_l10n.sh
@@ +20,5 @@
>  # if you choose to use your own credentials, you also have to change the
>  # hg push line below.
> +HG_USER="${HG_USER:-ffxbld <[e-mail]>}"      # used for commit message
> +HG_SSH_USER="${HG_SSH_USER:-ffxbld}"                    # used to push
> +SSH_KEY="${SSH_KEY:-$PWD/ffxbld_rsa}"

The comment needs updating, I think. All three vars must be set by a non-releng user, but otherwise it should just work.

Comment 7

[Hal Wine [:hwine] use NI!]

Comment on attachment 8600727 [details] [diff] [review]
Be less silent & add cleanup option

https://hg.mozilla.org/build/braindump/rev/45193776a4b5