[Stingray][Home] After a card is added into a folder, align the folder list to the folder card

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::Home
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: yifan, Assigned: rexboy)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1117699 +++

In edit mode, after a card is added into a folder, align the folder list to the folder card.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
(Reporter)

Updated

3 years ago
Assignee: tzhuang → yliao
(Reporter)

Updated

3 years ago
Assignee: yliao → nobody
Status: ASSIGNED → NEW
(Reporter)

Comment 1

3 years ago
Created attachment 8602481 [details] [diff] [review]
1158665_patch.diff

This is the patch that fixes 

* Add a card into the last position in a folder when a folderScrollobale is reversed.
* Align the folderScrollable to the hovered folder in the cardScrollable when a card is added into an empty folder.
Flags: needinfo?(rexboy)
Assignee: nobody → rexboy
Flags: needinfo?(rexboy)
Created attachment 8602679 [details] [review]
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master
Comment on attachment 8602679 [details] [review]
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master

The patch.

Tzu-lin may you help on reviewing this patch? If you are not available I can try changing reviewer.

Setting f? to yifan too.
Attachment #8602679 - Flags: review?(tzhuang)
Attachment #8602679 - Flags: feedback?(yliao)
Comment on attachment 8602679 [details] [review]
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master

This looks good to me. Thanks
Attachment #8602679 - Flags: review?(tzhuang) → review+
(Reporter)

Updated

3 years ago
Attachment #8602679 - Flags: feedback?(yliao) → feedback+
(Reporter)

Comment 5

3 years ago
Thanks for the patch!
After discussing with Yifan
We found the animation of moving card down to folderScrollable doesn't work as expect when:
(1)folder is rearranged and empty
(2)folder is at the edge of screen.
I'll open follow-up bug for it.
Thanks for taking care of the patch Tzu-lin and Yifan.
master:
https://github.com/mozilla-b2g/gaia/commit/3692ad2cf3a047cc66f58f655a56b6ec559ef253
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1162918
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]

Updated

3 years ago
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.