1158713 - "New e10s Window" menuitem should be hidden when browser does not support e10s

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[Alice0775 White]

After landing Bug 1155976 and Bug 115827.
Flash plungin not working sometimes. 
Page is blank. Nothing to load.
Shutdown crash


Steps to reproduce(Windows8.1/10TP):
1. Start Nightly(fx-team cset f43178fc99aa)
   and disable e10s when e10s notification pops up.(due to accessibility is not support)
   --- then Nightly will be restated 
2. Open http://www.adobe.com/software/flash/about/
   --- Flash Plugin working as expected
3. Open new e10s window from menu
4. Open http://www.adobe.com/software/flash/about/
   --- Page is blank. Nothing to load.
5. Quit Nightly
   --- Crashes

Actual Results:
Not working properly.
Crashes when shutdown

Expected results:
Browser should be working properly.
Not crash.

OR

"New e10s Window" menuitem should be hidden when browser does not support e10s.
And vice versa

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 2

[Benjamin Smedberg]

Alice, do you have crash IDs?

Does this only happen if you mix e10s and non-e10s windows?

Comment 3

[Alice0775 White]

https://hg.mozilla.org/mozilla-central/rev/caf25344f73e
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 ID:20150428030209

bp-30677552-71d5-4ff1-8dee-75a442150428

Comment 4

[Jim Mathies [:jimm]]

(In reply to Alice0775 White from comment #0)
> After landing Bug 1155976 and Bug 115827.
> Flash plungin not working sometimes. 
> Page is blank. Nothing to load.
> Shutdown crash
> 
> 
> Steps to reproduce(Windows8.1/10TP):
> 1. Start Nightly(fx-team cset f43178fc99aa)
>    and disable e10s when e10s notification pops up.(due to accessibility is
> not support)
>    --- then Nightly will be restated 
> 2. Open http://www.adobe.com/software/flash/about/
>    --- Flash Plugin working as expected
> 3. Open new e10s window from menu
> 4. Open http://www.adobe.com/software/flash/about/
>    --- Page is blank. Nothing to load.
> 5. Quit Nightly
>    --- Crashes

Alice, in step #3 did you mean open a non-e10s window?

I can't reproduce using your steps here using "open new window" or ctrl-n which gives me a new e10s window.

Comment 5

[Jim Mathies [:jimm]]

The shutdown hang+crash alice ran into is bug 1127270.

Comment 6

[Alice0775 White]

(In reply to Jim Mathies [:jimm] from comment #4)
> (In reply to Alice0775 White from comment #0)
> > After landing Bug 1155976 and Bug 115827.
> > Flash plungin not working sometimes. 
> > Page is blank. Nothing to load.
> > Shutdown crash
> > 
> > 
> > Steps to reproduce(Windows8.1/10TP):
> > 1. Start Nightly(fx-team cset f43178fc99aa)
> >    and disable e10s when e10s notification pops up.(due to accessibility is
> > not support)
> >    --- then Nightly will be restated 
> > 2. Open http://www.adobe.com/software/flash/about/
> >    --- Flash Plugin working as expected
> > 3. Open new e10s window from menu
> > 4. Open http://www.adobe.com/software/flash/about/
> >    --- Page is blank. Nothing to load.
> > 5. Quit Nightly
> >    --- Crashes
> 
> Alice, in step #3 did you mean open a non-e10s window?

No. New e10s Window.

 
> 
> I can't reproduce using your steps here using "open new window" or ctrl-n
> which gives me a new e10s window.

So,probably, your pc does not activate any accessibility tool.

On my pc, E10s is disabled by default on Windows10TP due to an accessibility tool is or was active. (I do not know which is the accessibility tool)

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Jim Mathies [:jimm] from comment #5)
> The shutdown hang+crash alice ran into is bug 1127270.

Given the crash is captured there, I'm going to change the bug summary to describe the remaining issue.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Jimm, I think this remaining work (to disable the e10s window menu option) got done somewhere else but I'm not sure where. Can this bug be closed?

Comment 9

[Jim Mathies [:jimm]]

yeah, looks like we removed it.