Closed Bug 1158791 Opened 9 years ago Closed 9 years ago

Allow Gtk's nsBidiKeyboard.cpp to Reset without a display

Categories

(Core :: Widget: Gtk, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mconley, Assigned: mrbkap)

Details

Attachments

(1 file)

While helping me with bug 1096093, mrbkap noticed that nsBidiKeyboard::Reset would crash if executed with no display present (for example, when running xpcshell tests).

He had a small patch to fix that, but I unfortunately lost it in the shuffle when getting my patches for bug 1096093 landed.

I just wanted to get this on file so that we didn't forget about it.
Thanks for filing this, Mike.

To be clear: we don't crash, but I do get: "Gdk-CRITICAL **: IA__gdk_keymap_get_for_display: assertion 'GDK_IS_DISPLAY (display)' failed" which we should probably avoid and which might make debugging similar stuff in xpcshell tests annoying in the future.
Attached patch patch v1Splinter Review
Attachment #8598231 - Flags: review?(karlt)
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Comment on attachment 8598231 [details] [diff] [review]
patch v1

Please add an entry here for gdk_keymap_get_for_display to keep GTK3 port building:
https://hg.mozilla.org/mozilla-central/annotate/e0299ad29b85/widget/gtk/mozgtk/mozgtk.c#l45
Attachment #8598231 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/680013c9718f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.