1158798 - [e10s] If mouse is plugged in, inline scrollbars are not used even if OS X is configured for them

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

STR:

1) In OS X's System Preferences, under "General", make sure the "Show scroll bars" setting is set to "Automatically based on mouse or trackpad".
2) In Firefox, with e10s in a tab that can scroll, plug in a mouse
3) The inline scrollbars appear.
4) Restart the browser (and restore your previous session)
5) When the browser starts up and the session restores, the overlay scrollbars are used instead.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

> 4) Restart the browser (and restore your previous session)

How, exactly, do you do this?

Do you have a regression range?

Comment 2

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

(In reply to Steven Michaud from comment #1)
> > 4) Restart the browser (and restore your previous session)
> 
> How, exactly, do you do this?

Two ways - Firefox can be configured to do this automatically in about:preferences in the General pane, "When &shortBrandName; starts" needs to be set to "Show my windows and tabs from last time".

Alternatively, if you get to about:home on start-up, to the right of the buttons at the bottom of the page, there should be a button to restore your previous session.

Either will do.

> 
> Do you have a regression range?

Not really. The inline scrollbars didn't really work with e10s until bug 1096093 landed - it just looked like I missed a case when fixing that bug.

Comment 3

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

Attachment: MozReview Request: Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.

Comment 4

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

https://reviewboard.mozilla.org/r/13035/#review11621

::: widget/LookAndFeel.h:599
(Diff revision 1)
> -  static nsTArray<LookAndFeelInt> GetIntCache();
> +  static void GetIntCache(nsTArray<LookAndFeelInt>* aLookAndFeelIntCache);

Let's keep the original signature, as Markus requested.

Comment 5

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

Comment on attachment 8632299 [details]
MozReview Request: Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.

Comment 6

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

Comment on attachment 8632299 [details]
MozReview Request: Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.

Comment 7

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

Are you good to review this whole thing, Markus? Or should I request review from jimm as well?

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8632299 [details]
MozReview Request: Bug 1158798 - Properly initialize the LookAndFeel cache in the child.

https://reviewboard.mozilla.org/r/13035/#review11643

Ship It!

Comment 9

[Markus Stange [:mstange]]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #7)
> Are you good to review this whole thing, Markus? Or should I request review
> from jimm as well?

I think my review is sufficient here. This is pretty non-controversial stuff.

Comment 10

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/836d79194ff1bd3789b8d5a05af8ab858db20d58
changeset:  836d79194ff1bd3789b8d5a05af8ab858db20d58
user:       Mike Conley <[e-mail]>
date:       Fri Jul 10 17:11:59 2015 -0400
description:
Bug 1158798 - Properly initialize the LookAndFeel cache in the child. r=mstange.

The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/836d79194ff1

Comment 12

[Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos)]

Attachment: Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1158798.html