Closed
Bug 1158859
Opened 9 years ago
Closed 9 years ago
Update newtab cog menu styling
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: emtwo, Assigned: emtwo)
References
(Blocks 1 open bug)
Details
(Whiteboard: .001 [strings])
Attachments
(5 files)
24.81 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
13.58 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
25.77 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
24.70 KB,
patch
|
Details | Diff | Splinter Review | |
39.94 KB,
image/png
|
Details |
Based on mocks here: https://bug1150228.bugzilla.mozilla.org/attachment.cgi?id=8592387
Assignee | ||
Updated•9 years ago
|
Whiteboard: [strings]
Updated•9 years ago
|
Iteration: --- → 40.3 - 11 May
Whiteboard: .? [strings] → .001 [strings]
Assignee | ||
Comment 1•9 years ago
|
||
Aaron, here's a build with the updated cog menu. Please let me know how this looks: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/msamuel@mozilla.com-4fb94d051c6b/try-macosx64/firefox-40.0a1.en-US.mac.dmg
Flags: needinfo?(athornburgh)
Assignee | ||
Comment 2•9 years ago
|
||
There's a link to a build to test out in comment 1 as well.
Attachment #8601608 -
Flags: review?(adw)
Comments: 1.) Round the top corners of the menu dropdown container. 2.) On rollover, "Learn about new Tab" should be a blue bg with white text. 3.) Can we get rid of "What is this page?"? Pretty please! Looks great - thank you.
Flags: needinfo?(athornburgh)
Comment 4•9 years ago
|
||
(In reply to Aaron from comment #3) > 3.) Can we get rid of "What is this page?"? Pretty please! That's a separate bug 1145303
Comment 5•9 years ago
|
||
Comment on attachment 8601608 [details] [diff] [review] part 1: v1: Update newtab cog menu styling >+++ b/browser/base/content/newtab/newTab.xul >+ <xul:label>New Tab Controls</xul:label> >+ <xul:label>Show your top sites</xul:label> We should have these as .dtd for Nightly 40 to support all locales (not just en-US). When we uplift to Aurora 39, we'll hardcode for en-US only and show the old menu for non-en-US.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Ed Lee :Mardak from comment #5) > Comment on attachment 8601608 [details] [diff] [review] > v1: Update newtab cog menu styling > > >+++ b/browser/base/content/newtab/newTab.xul > >+ <xul:label>New Tab Controls</xul:label> > >+ <xul:label>Show your top sites</xul:label> > We should have these as .dtd for Nightly 40 to support all locales (not just > en-US). When we uplift to Aurora 39, we'll hardcode for en-US only and show > the old menu for non-en-US. This patch has hard-coded strings so it can be uplifted to Aurora. I assume we want to land this first then have a follow-up that puts the strings into a .dtd for nightly?
Comment 7•9 years ago
|
||
Sorry for the confusing timeline. We want to get strings into Nightly 40 before it becomes Aurora 40 so that 40 gets translated to all locales. We have a little bit more flexibility on uplifting hardcoded en-US strings because that doesn't break string freeze.
Assignee | ||
Comment 8•9 years ago
|
||
This patch goes on top of the hard-coded strings patch to remove hard-coding and add localizable strings.
Attachment #8602438 -
Flags: review?(adw)
Comment 9•9 years ago
|
||
I combined emtwo's two patches into one that would be landing for nightly. We want to get this in before 40's string freeze when it moves to aurora.
Attachment #8602881 -
Flags: review?(adw)
Comment 10•9 years ago
|
||
Comment on attachment 8601608 [details] [diff] [review] part 1: v1: Update newtab cog menu styling clearing r? for now as this patch is for later uplift to 39
Attachment #8601608 -
Flags: review?(adw)
Comment 11•9 years ago
|
||
Comment on attachment 8602438 [details] [diff] [review] part 2 [strings] v1: Update newtab cog menu styling see attachment 8602881 [details] [diff] [review] for the combined patch
Attachment #8602438 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8601608 -
Attachment description: v1: Update newtab cog menu styling → part 1: v1: Update newtab cog menu styling
Updated•9 years ago
|
Attachment #8602438 -
Attachment description: [strings] v1: Update newtab cog menu styling → part 2 [strings] v1: Update newtab cog menu styling
Updated•9 years ago
|
Attachment #8601608 -
Flags: review+
Updated•9 years ago
|
Attachment #8602438 -
Flags: review+
Comment 12•9 years ago
|
||
Comment on attachment 8602881 [details] [diff] [review] for nightly combined Review of attachment 8602881 [details] [diff] [review]: ----------------------------------------------------------------- Carrying over r+ on this combined patch. I didn't actually look at it.
Attachment #8602881 -
Flags: review?(adw) → review+
Updated•9 years ago
|
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ff746c53035c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Points: --- → 8
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Verified on os x nightly 2015-05-24 1) open new tab 2) point at top right customize menu and see the new border/styling 3) click customize icon and see the page fade out 4) checked hover behavior of "Show your top sites" and "Show blank page" 5) click options changes the new tab page for suggestions and blank 6) tested "learn about New Tab" (but page is still outdated) Ran into Bug 1168628 where ctrl-tab switching away from the page causes the menu popup to disappear and leaves the page unusable until refresh.
status-firefox41:
--- → verified
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
Comment 17•9 years ago
|
||
Comment 18•9 years ago
|
||
Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora, build ID: 20150528004000.
You need to log in
before you can comment on or make changes to this bug.
Description
•