1158876 - Gonk socket I/O code always forwards data to main thread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The socket I/O code in ipc/unixsocket always forwards received data to the main thread. This constraint must be removed if we want to optimize existing users or allow for new use cases, such as in BluetoothDaemonConnection.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1158876: Rename |SocketConsumerBase| to |DataSocket|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1158876: Move management of socket I/O buffers into socket I/O classes

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1158876: Move |DataSocket::ReceiveSocketData| into sub classes

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94b687180bd1

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8598076 [details] [diff] [review]
[01] Bug 1158876: Rename |SocketConsumerBase| to |DataSocket|

Review of attachment 8598076 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/unixsocket/ListenSocket.cpp
@@ +137,5 @@
>  
> +DataSocket*
> +ListenSocketIO::GetDataSocket()
> +{
> +  return nullptr; // listen sockets cannot transfer data

Nit: Is it worth asserting here?

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1158876: Rename |SocketConsumerBase| to |DataSocket| (v2)

Changes since v1:

  - crash when requesting |DataSocket| from |ListenSocketIO|

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/8a3ef82cb417
https://hg.mozilla.org/integration/b2g-inbound/rev/730c7f25b895
https://hg.mozilla.org/integration/b2g-inbound/rev/7e28d47294b2

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot. I added MOZ_CRASH to |ListenSocketIO::GetDataSocket|, but this will be cleaned up in another, larger patch set.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=7e28d47294b2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a3ef82cb417
https://hg.mozilla.org/mozilla-central/rev/730c7f25b895
https://hg.mozilla.org/mozilla-central/rev/7e28d47294b2