Closed Bug 1158887 Opened 9 years ago Closed 7 years ago

Intermittent test_async_transactions.js | xpcshell return code: 0 | test_add_and_remove_livemark

Categories

(Toolkit :: Places, defect, P3)

Unspecified
Windows XP
defect
Points:
1

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox39 --- unaffected
firefox40 --- disabled
firefox41 --- disabled
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: RyanVM, Assigned: mak)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on WinXP][leave open])

Attachments

(2 files)

Attached file test log —
+++ This bug was initially created as a clone of Bug #1158833 +++

Same issue as bug 1158833?
Flags: needinfo?(mak77)
no, this looks like an actual bug in async transactions that the livemarks change uncovered.
Blocks: 1071513
Flags: needinfo?(mak77)
should be fixed by bug 1095425
Depends on: 1095425
(In reply to Marco Bonardo [::mak] from comment #30)
> should be fixed by bug 1095425

This is a top orange on multiple trees now. Can we please disable the test until bug 1095425 is ready to land?
Flags: needinfo?(mak77)
I will extract the fix from that bug and land it.
Assignee: nobody → mak77
Flags: needinfo?(mak77)
Attached patch patch v1 — — Splinter Review
this is Mano's patch from bug 1095425 with minor test fixes.
Attachment #8612793 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/75de13bc160f
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Please nominate this for Aurora approval when you get a chance.
Blocks: 1094900
Flags: needinfo?(mak77)
Comment on attachment 8612793 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: bug 1094900
[User impact if declined]: lastModified of livemarks is wrong (this also causes intermittent failures in our tests)
[Describe test coverage new/current, TreeHerder]: m-c, unit tests
[Risks and why]: low risk, simple change with tests
[String/UUID change made/needed]: none
Attachment #8612793 - Flags: approval-mozilla-aurora?
Attachment #8612793 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Looks like Trunk and Aurora are both hitting the test_livemark_txns failures on WinXP still.
Status: RESOLVED → REOPENED
Flags: needinfo?(mak77)
Resolution: FIXED → ---
Target Milestone: mozilla41 → ---
This looks interesting:

11:52:12 INFO - PROCESS | 4308 | Message: Error: Invalid value for property 'lastModified': Tue Jun 02 2015 11:52:09 GMT-0800 (Pacific Standard Time)
11:52:12 INFO - PROCESS | 4308 | Stack:
11:52:12 INFO - PROCESS | 4308 | validateBookmarkObject@resource://gre/modules/Bookmarks.jsm:1235:1
11:52:12 INFO - PROCESS | 4308 | update/<@resource://gre/modules/Bookmarks.jsm:253:20
11:52:12 INFO - PROCESS | 4308 | update@resource://gre/modules/Bookmarks.jsm:233:1
11:52:12 INFO - PROCESS | 4308 | addLivemark/<@resource://gre/components/nsLivemarkService.js:236:15
11:52:12 INFO - PROCESS | 4308 | addLivemark@resource://gre/components/nsLivemarkService.js:193:1
11:52:12 INFO - PROCESS | 4308 | PT.NewLivemark.prototype<.execute/createItem@resource://gre/modules/PlacesTransactions.jsm:1173:28
I think it's not wise to debug the intermittent with the current code, I fixed the obvious cause, but here we have some fancy stuff ongoing with the new transactions. I suspect PlacesTransaction is trying to set an lastModified that is smaller than dateAdded. That's a bug there that should be fixed in bug 1095425.
It might be happening only on Windows due to timers resolution difference between PR_Now() and Date().
So, here I'd just vote to disable the test on Windows, and add a note in bug 1095425 about that.
Ryan, could you please do that?
Flags: needinfo?(mak77) → needinfo?(ryanvm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f59311a17ec5
Flags: needinfo?(ryanvm)
Whiteboard: [test disabled on WinXP][leave open]
Priority: -- → P3
We no longer test WinXP and bug 1336712 is removing this annotation.
Status: REOPENED → RESOLVED
Closed: 9 years ago7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.