This bug covers building tools to extract strings from BuddyUp, for use in the localization process outlined in bug 1128546 comment 2. These tools need to 1) Extract strings from JS code from gettext and ngettext callsites. 2) Be compatible with Nunjucks template files. This may take the form of extracting from pre-compiled templates, or parsing the original source directly. 3) Output a .po file compatible with Kitsune's localization process. This took me a while when I did it in Yaocho. Hopefully some of that work will carry over, but I still think it wise to estimate this at 3 points.
NB: This covers step #1 in bug 1128546 comment 2.
Moving to next sprint.
Whiteboard: u=user c=buddyup p=3 s=2015.8 → u=user c=buddyup p=3 s=2015.9
Any updates on this review?
Sorry for the long review time. Right now, I can't run the extract command on my computer. It gives me two errors and I can't find any buddyup.pot file in my tree. Output: $ grunt extract --force Running "extract:buddyup" (extract) task Warning: Cannot localize non-literal at app/js/l10n.js:32 Used --force, continuing. Warning: Cannot read property 'filepath' of null Used --force, continuing. Done, but with warnings.
buddyup.pot is a generated file, and shouldn't be in the repository. I fixed the non-literal error in my latest push.
I meant that buddyup.pot wasn't generated on my computer after using the extract command. Anyway, it is now working, without any warning and creating the file. I'll finish the review tomorrow.
Comment on attachment 8610549 [details] [review] https://github.com/mozilla/buddyup/pull/162 That's very nice! I've left two comments on Github. There are some jshint errors but nothing major to fix. Let's keep the generated templates.js. Although it's a nice cleanup, I don't want to change the process our QA uses at the moment. I also want to land this work in a l10n branch so that we can keep the master branch clean and merge once all the pieces are in place. I can make all the changes and land this if you're busy with other stuff.
All changes made and uploaded to the l10n branch: https://github.com/mozilla/buddyup/tree/l10n.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.