1158956 - Putting non-existent apps into default-homescreens.json takes down the Homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

See URL for test data.

When booting with this default-homescreens.json file, I get the following error:
W/Homescreen(13398): [JavaScript Error: "TypeError: item is null" {file: "app://verticalhome.gaiamobile.org/js/configurator.js" line: 209}]

The Homescreen is also completely gone from view with just one empty section. It's likely bailing from handling/rendering on the first non-existent app.

We should at the very least handle this gracefully and not attempt to include non-existent apps in the Homescreen view.

Comment 1

[Doug Sherk (:drs) (inactive)]

Kevin, could you take this, as you said on IRC? Thanks.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1158956_homescreen_invalid_app_safety > mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8598214 [details] [review]
[gaia] KevinGrandon:bug_1158956_homescreen_invalid_app_safety > mozilla-b2g:master

Chris - would you mind giving this a quick look? This is the easiest fix I could find to allow the guys working on spark to get unblocked. Thanks!

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8598214 [details] [review]
[gaia] KevinGrandon:bug_1158956_homescreen_invalid_app_safety > mozilla-b2g:master

lgtm. Maybe a unit test for this would be nice? If it's easy to write, at least.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Chris Lord [:cwiiis] from comment #4)
> Comment on attachment 8598214 [details] [review]
> lgtm. Maybe a unit test for this would be nice? If it's easy to write, at
> least.

I have been trying to write one, but this configurator stuff is way too tricky with all of the svapps stuff, tbh I'm a bit lost in there :-p Going to land for now, but also going to start thinking about how to fix this stuff.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6e35b0948c42a4398b8a5916015de167121683a1