Closed Bug 1158956 Opened 5 years ago Closed 5 years ago

Putting non-existent apps into default-homescreens.json takes down the Homescreen

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: kgrandon)

References

()

Details

(Whiteboard: [systemsfe][spark])

Attachments

(1 file)

See URL for test data.

When booting with this default-homescreens.json file, I get the following error:
W/Homescreen(13398): [JavaScript Error: "TypeError: item is null" {file: "app://verticalhome.gaiamobile.org/js/configurator.js" line: 209}]

The Homescreen is also completely gone from view with just one empty section. It's likely bailing from handling/rendering on the first non-existent app.

We should at the very least handle this gracefully and not attempt to include non-existent apps in the Homescreen view.
Kevin, could you take this, as you said on IRC? Thanks.
Flags: needinfo?(kgrandon)
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(kgrandon)
Whiteboard: [spark] → [systemsfe][spark]
Comment on attachment 8598214 [details] [review]
[gaia] KevinGrandon:bug_1158956_homescreen_invalid_app_safety > mozilla-b2g:master

Chris - would you mind giving this a quick look? This is the easiest fix I could find to allow the guys working on spark to get unblocked. Thanks!
Attachment #8598214 - Flags: review?(chrislord.net)
Comment on attachment 8598214 [details] [review]
[gaia] KevinGrandon:bug_1158956_homescreen_invalid_app_safety > mozilla-b2g:master

lgtm. Maybe a unit test for this would be nice? If it's easy to write, at least.
Attachment #8598214 - Flags: review?(chrislord.net) → review+
(In reply to Chris Lord [:cwiiis] from comment #4)
> Comment on attachment 8598214 [details] [review]
> lgtm. Maybe a unit test for this would be nice? If it's easy to write, at
> least.

I have been trying to write one, but this configurator stuff is way too tricky with all of the svapps stuff, tbh I'm a bit lost in there :-p Going to land for now, but also going to start thinking about how to fix this stuff.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1159457
No longer blocks: 1158367
You need to log in before you can comment on or make changes to this bug.