Closed Bug 1158991 Opened 5 years ago Closed 4 years ago

720p The clock button text sits too low

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

Attachments

(2 files)

Attached image 2015-04-27-12-42-08.png
The baseline of the text within the clock buttons sits too low, it should appear centered within the button.
Attached file patch for Gaia/master
Attachment #8614846 - Flags: ui-review?(amlee)
Assignee: nobody → pivanov
Comment on attachment 8614846 [details] [review]
patch for Gaia/master

Hi Pavel, 

Can you please move the text in both buttons 2px up? 

Thanks!
Attachment #8614846 - Flags: ui-review?(amlee) → ui-review-
Attachment #8614846 - Flags: ui-review- → ui-review?(amlee)
Comment on attachment 8614846 [details] [review]
patch for Gaia/master

Looks good! Thanks
Attachment #8614846 - Flags: ui-review?(amlee) → ui-review+
Comment on attachment 8614846 [details] [review]
patch for Gaia/master

Hey Marcus,
can you r+?
Attachment #8614846 - Flags: review?(m)
Attachment #8614846 - Flags: review?(m) → review+
Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/1415c1b3679ab6cae3d9974b4ad86306ffb3b021
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.