11590 - eliminate NS_COMFALSE

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Warren Harris]

We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.


      editor/base/DeleteRangeTxn.cpp:
            View change log or Blame annotations
            line 341
      editor/base/EditTable.cpp:
            View change log or Blame annotations
            line 431
      editor/base/nsHTMLEditor.cpp:
            View change log or Blame annotations
            line 597
            line 2051
            line 2958
            line 3573
            line 3649
            line 3697
            line 5081
            line 5654
      editor/base/nsEditor.cpp:
            View change log or Blame annotations
            line 2414
            line 2527
            line 3387
      editor/base/nsTextEditor.cpp:
            View change log or Blame annotations
            line 567
            line 879
            line 927
            line 2160
            line 2732
            line 3057
      editor/base/nsHTMLEditRules.cpp:
            View change log or Blame annotations
            line 1326
            line 1653
      editor/txmgr/src/nsTransactionItem.cpp:
            View change log or Blame annotations
            line 170
            line 259
      editor/txmgr/src/nsTransactionManager.cpp:
            View change log or Blame annotations
            line 129
            line 209
            line 288
            line 352
            line 411
            line 726
            line 776
            line 826
            line 876
            line 926
            line 976
            line 1142
      editor/txtsvc/src/nsTextServicesDocument.cpp:
            View change log or Blame annotations
            line 426
            line 496
            line 720
            line 847
            line 966
            line 1201
            line 1328
            line 1447
            line 1534
            line 1607
            line 3287
            line 3338
            line 3593
            line 3634
            line 3870
            line 3944
            line 3995
            line 4039
            line 4089

Comment 1

[Simon Fraser [no longer active]]

cc: other editor folks.

Comment 2

[Simon Fraser [no longer active]]

Fix your instances, and pass the rest along...

Comment 3

[kinmoz]

Accepting bug.

Comment 4

[Brad Roberts]

I've moved all of the NS_COMFALSE's that deal with enumerators over to
NS_ENUMERATOR_FALSE as a first phase of this.  The next phases are underway to
remove the rest of the NS_COMFALSE usage.  More soon.

Comment 5

[kinmoz]

I have a fixes for the editor/txmgr directory. I will check it in once the
Commercial tree opens for M12 checkins.

Comment 6

[kinmoz]

Checked in fixes for the TransactionManager's use of NS_COMFALSE:

    mozilla/editor/base/nsEditorTxnLog.cpp               revision 1.4
    mozilla/editor/base/nsEditorTxnLog.h                 revision 1.4
    mozilla/editor/txmgr/public/nsITransactionListener.h revision 1.8
    mozilla/editor/txmgr/src/nsTransactionItem.cpp       revision 1.15
    mozilla/editor/txmgr/src/nsTransactionManager.cpp    revision 1.27
    mozilla/editor/txmgr/src/nsTransactionManager.h      revision 1.14

r=[e-mail]

That should be all for the editor directory. Not sure if [e-mail] is
going to do a second phase pass to deal with NS_ENUMERATOR_FALSE.

Comment 7

[kinmoz]

I'm closing this bug as fixed. There are no more references to NS_COMFALSE in
the editor directory.

If we are also going to get rid of NS_ENUMERATOR_FALSE, it should be filed as
a different bug.

Comment 8

[kinmoz]

Just verified with LXR that there are no instances of NS_COMFALSE in the editor
directory. Marking VERIFIED.