Closed Bug 1159009 Opened 9 years ago Closed 9 years ago

Add trait for WebConsoleCommands

Categories

(DevTools :: Console, defect)

38 Branch
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: fayolle-florent, Assigned: fayolle-florent)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150420134330

Steps to reproduce:

The WebConsoleCommands API has been introduced with bug 1143497. We should add a trait for it.

Florent
Component: Untriaged → Developer Tools: Console
Attached patch 1159009.patchSplinter Review
One line and two comments. Hard to read :).

Florent
Attachment #8598258 - Flags: review?(bgrinstead)
Attachment #8598258 - Flags: review?(bgrinstead) → review+
Assignee: nobody → fayolle-florent
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Depends on: 1143497
Attached patch 922212.patch (obsolete) — Splinter Review
I just changed the browser/devtools/webconsole/test/test-console-extras.html file (the file tests unimplemented console methods, but console.dirxml() is now).

Brian, could you make another push test please?

Florent
Attachment #8598258 - Attachment is obsolete: true
Attachment #8599420 - Flags: review?(bgrinstead)
(In reply to fayolle-florent from comment #2)
> Created attachment 8599420 [details] [diff] [review]
> 922212.patch
> 
> I just changed the browser/devtools/webconsole/test/test-console-extras.html
> file (the file tests unimplemented console methods, but console.dirxml() is
> now).

I think this patch was intended for Bug 922212
Attachment #8599420 - Attachment is obsolete: true
Attachment #8599420 - Flags: review?(bgrinstead)
Attachment #8598258 - Attachment is obsolete: false
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/44a83132bb19
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.