Closed
Bug 1159009
Opened 9 years ago
Closed 9 years ago
Add trait for WebConsoleCommands
Categories
(DevTools :: Console, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: fayolle-florent, Assigned: fayolle-florent)
References
Details
Attachments
(1 file, 1 obsolete file)
1.46 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Build ID: 20150420134330 Steps to reproduce: The WebConsoleCommands API has been introduced with bug 1143497. We should add a trait for it. Florent
Assignee | ||
Updated•9 years ago
|
Component: Untriaged → Developer Tools: Console
Assignee | ||
Comment 1•9 years ago
|
||
One line and two comments. Hard to read :). Florent
Attachment #8598258 -
Flags: review?(bgrinstead)
Updated•9 years ago
|
Attachment #8598258 -
Flags: review?(bgrinstead) → review+
Updated•9 years ago
|
Assignee: nobody → fayolle-florent
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 2•9 years ago
|
||
I just changed the browser/devtools/webconsole/test/test-console-extras.html file (the file tests unimplemented console methods, but console.dirxml() is now). Brian, could you make another push test please? Florent
Attachment #8598258 -
Attachment is obsolete: true
Attachment #8599420 -
Flags: review?(bgrinstead)
Comment 3•9 years ago
|
||
(In reply to fayolle-florent from comment #2) > Created attachment 8599420 [details] [diff] [review] > 922212.patch > > I just changed the browser/devtools/webconsole/test/test-console-extras.html > file (the file tests unimplemented console methods, but console.dirxml() is > now). I think this patch was intended for Bug 922212
Updated•9 years ago
|
Attachment #8599420 -
Attachment is obsolete: true
Attachment #8599420 -
Flags: review?(bgrinstead)
Updated•9 years ago
|
Attachment #8598258 -
Attachment is obsolete: false
Comment 4•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=59b35d965a27
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44a83132bb19
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•