ScrollFrameHelper::SetCoordAttribute stores a value in css pixels in a variable with type nscoord

RESOLVED FIXED in Firefox 40

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
nscoord should be reserved for appunits.
(Assignee)

Comment 1

3 years ago
Created attachment 8598330 [details] [diff] [review]
patch
Attachment #8598330 - Flags: review?(dholbert)
Attachment #8598330 - Flags: review?(dholbert) → review+

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c738675bd82
https://hg.mozilla.org/mozilla-central/rev/2c738675bd82
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Why pizelSize rather than pixelSize?
Oops. Surely that was a typo.
Flags: needinfo?(tnikkel)
(Assignee)

Comment 6

3 years ago
Yes, it was a typo that went unnoticed. Thanks for noticing. I'll push a typo fix when I see inbound open. Leaving needinfo until that's done.

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2f3186febc2
(Assignee)

Comment 8

3 years ago
Pushed the typo fix.
Flags: needinfo?(tnikkel)
https://hg.mozilla.org/mozilla-central/rev/e2f3186febc2
You need to log in before you can comment on or make changes to this bug.