Closed Bug 1159082 Opened 5 years ago Closed 5 years ago

Rename *Readonly animation interfaces to *ReadOnly

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file, 1 obsolete file)

The Web Animations spec was recently updated[1] to match the capitalization in the geometry spec[2].

[1] https://github.com/w3c/web-animations/commit/8a9f98b1f91caee8e83c9e05112621d8245f9b8f
[2] http://dev.w3.org/fxtf/geometry/
/r/7727 - Bug 1159082 - Rename *Readonly animation interfaces to *ReadOnly

Pull down this commit:

hg pull -r 11a4510196b00b14e1e41838cdac2fb0a5e652d2 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8598369 - Flags: review?(bugs)
Comment on attachment 8598369 [details]
MozReview Request: bz://1159082/birtles

I don't know if MozReview just doesn't give a sane diff for file renames, but
if it does, and there isn't file rename happening, please do that, and not
file remove, file creation.
Talking about AnimationEffectReadonly.cpp and AnimationEffectReadonly.h and AnimationEffectReadonly.webidl
Attachment #8598369 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8598369 [details]
> MozReview Request: bz://1159082/birtles
> 
> I don't know if MozReview just doesn't give a sane diff for file renames, but
> if it does, and there isn't file rename happening, please do that, and not
> file remove, file creation.
> Talking about AnimationEffectReadonly.cpp and AnimationEffectReadonly.h and
> AnimationEffectReadonly.webidl

Yeah, it's definitely a rename. I guess MozReview doesn't handle that yet (it's the first time I've used it).
(In reply to Brian Birtles (:birtles) from comment #3)
> Yeah, it's definitely a rename. I guess MozReview doesn't handle that yet
> (it's the first time I've used it).

It turns out this is bug 1107547.
sorry had to back this out for perma test failures starting with this push like https://treeherder.mozilla.org/logviewer.html#?job_id=9443588&repo=mozilla-inbound
Flags: needinfo?(bbirtles)
(In reply to Carsten Book [:Tomcat] from comment #6)
> sorry had to back this out for perma test failures starting with this push
> like
> https://treeherder.mozilla.org/logviewer.html#?job_id=9443588&repo=mozilla-
> inbound

How on earth could changing the case of an interface cause that? :/
Flags: needinfo?(bbirtles)
Blocks: 1160129
https://hg.mozilla.org/mozilla-central/rev/b9583beee116
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8598369 - Attachment is obsolete: true
Attachment #8620169 - Flags: review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.