11591 - eliminate NS_COMFALSE

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P3)

Description

[Warren Harris]

We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.

      js/src/xpconnect/tests/TestXPC.cpp:
            View change log or Blame annotations
            line 447
      js/src/xpconnect/tests/components/xpctest_echo.cpp:
            View change log or Blame annotations
            line 266

Comment 1

[brendan-obsolete]

Wrong component, but close.

/be

Comment 2

[John Bandhauer]

Heck, this may be the only place in the code where we *should* use
NS_ERROR_COMFALSE. This is code that is used to test proper handling of
nsresults in xpconnect. I want to make sure to handle success codes as well as
error codes. Make sense?

Comment 3

[Warren Harris]

But I want to take it's definition out of the header file, so you'll need to
find something else for this purpose.

Comment 4

[leger]

Clearing Invalid resolution due to reopen.

Comment 5

[John Bandhauer]

OK fine. I have the fixes in hand. Ready when the tree opens.

Comment 6

[John Bandhauer]

all checked in