1159119 - MSE playback crashed in GonkMediaDataDecoder - episode 2

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

Attachment: test_mse_playback_ep2.patch

1. apply the patch to Central
2. have a debug build of emulator-kk on Central
3. run tests with |./mach mochitest-remote dom/media/test/test_mse_playback.html|
4. open |adb logcat|
5. hit the assertion: Assertion failure: !mManager->HasQueuedSample(), at ../../../../../../mozilla-central2/dom/media/fmp4/gonk/GonkMediaDataDecoder.cpp:227

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

This is the sequel of bug 1147258.

Hi Blake,
Can you check this bug?

Comment 2

[Blake Wu [:bwu][:blakewu]]

(In reply to JW Wang [:jwwang] from comment #1)
> This is the sequel of bug 1147258.
> 
> Hi Blake,
> Can you check this bug?
Oops... The same assertion but in different place. 
Sure! I will check it.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Btw, I also hit the same assertion when running
|./mach mochitest-plain dom/media/test/test_bug495145.html| on emulator-kk.

Comment 4

[Blake Wu [:bwu][:blakewu]]

I am finally able to add some logs and successfully repro this bug. 
The rootcause looks like MP4Reader calls drain() twice and the second drain() causes to input a null data (for EOS notification) again which makes the input queue not empty and causes the assertion.

Comment 5

[Blake Wu [:bwu][:blakewu]]

I noticed bug 1161903 should be related to this bug as described in comment 4. 
After syncing my code base to the latest, I cannot repro this bug anymore. 
jwwang, 
Are you able to repro this bug now?

Comment 6

[Blake Wu [:bwu][:blakewu]]

Attachment: Avoid-doing-drain-again-if-it-is-already-completed.patch

Although MP4Reader doesn't call drain twice now, we should make our PDM more robust.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

No, I can't see the assertion anymore. test_bug495145.html didn't hit the assertion either. However, there is something wrong to test_mse_playback.html which hang the test.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Closing as we are not working on Firefox OS anymore.