1159162 - Remove unnecessary testing prefs from media mochitests

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6af733ba00d

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1159162_remove_unnecessary_prefs-v1.patch

Remove unnecessary testing prefs from media mochitests for they are defined in testing/profiles/prefs_general.js.

https://hg.mozilla.org/mozilla-central/file/e0299ad29b85/testing/profiles/prefs_general.js#l167

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd47e2a22f96

Comment 5

[Boris Zbarsky [:bzbarsky]]

Can we please back this out?  I'm in the middle of trying to _remove_ these prefs from the default testing profile because that's screwing up some other tests; see bug 1159756.

Comment 6

[Boris Zbarsky [:bzbarsky]]

And in particular, the only reason for the harness-wide annotation was web platform tests, but those can now do pref annotations themselves, and I was planning to just add them.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Specifically, the media.mediasource.enabled pref is the one I would like to continue setting per-test.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Sure. Please back it out. Sorry for causing the trouble.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd47e2a22f96

Comment 10

[Boris Zbarsky [:bzbarsky]]

OK.  I'll do that for the parts of it that matter to me in bug 1159756.  Thanks for following up quickly!