Closed
Bug 1159167
Opened 9 years ago
Closed 9 years ago
Update to latest django-browserid
Categories
(Tree Management :: Treeherder, defect, P4)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: mdoglio)
References
Details
Attachments
(1 file)
In bug 1118023, we attempted to update to django-browserid 0.11.1, however v0.11 made breaking changes that requires us to update the UI handling too. As such, in that bug we just updated as far as v0.10, to stop the peep issues associated with using a revision SHA rather than a version number. Updating to v0.11.1 (or newer) will: * Fix the "ImproperlyConfigured: Setting BROWSERID_VERIFY_CLASS not found" false positive warning seen in the logs (see bug 1118023 comment 0). * Mean django 1.7 (and soon 1.8) are officially supported/tested in django-browswerid upstream. * Mean we use Persona's new stateless API, which apparently avoids some issues with auto-login/logout. http://django-browserid.readthedocs.org/en/latest/contributor/changelog.html https://github.com/mozilla/django-browserid/compare/v0.10...v0.11.1 For the changes that will be required to the UI, see: https://github.com/mozilla/django-browserid/issues/285#issuecomment-96741951 Our UI handling is here: https://github.com/mozilla/treeherder-ui/blob/5b87e9693f43b50b3069d3b06d0f14fc47a055b5/webapp/app/js/services/main.js#L91 https://github.com/mozilla/treeherder-ui/blob/2f7f9d92f5bcbdaf62d232447f787adbbbfa169e/webapp/app/js/directives/persona.js
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → emorley
Reporter | ||
Updated•9 years ago
|
Assignee: emorley → nobody
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mdoglio
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8650405 -
Flags: review?(emorley)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8650405 [details] [review] PR 890 Thank you for looking at this :-)
Attachment #8650405 -
Flags: review?(emorley) → review+
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/caebeeb79431b8dba4bc42e0fc8f40666473a5f3 Bug 1159167 - Update to latest django-browserid The latest version of django-browserid removes a view that we used to fetch to retrieve basig config params for the browserid client initialization. We now have loginUrl and logoutUrl hardcoded in the client and we fetch the user login status from a dedicated endpoint.
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•