1159170 - [Contacts]"cannot use memory card because USB storage is enabled" is too close to the right edge of screen.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: Portuguese Portugal_mememory.png

[1.Description]:
[Flame2.2][Contacts]"cannot use memory card because USB storage is enabled" is too close to the right edge of screen on the export contacts page.

See attachment:Portuguese Portugal_mememory.png

[2.Testing Steps]: 
Prerequisites:Set device language to  Portuguese Portugal , Have at least 1 contact in the contacts app. Have USB storage Enabled in Settings
1. Open the Contacts app 
2. Tap on the gear icon to open settings 
3.Tap on 'Export Contacts' 
4. Plug the device into the computer 
 
[3.Expected Result]: 
4."cannot use memory card because USB storage is enabled"  should fit the screen width.

[4.Actual Result]: 
4."cannot use memory card because USB storage is enabled" is too close to the right edge of screen.

[5.Reproduction build]: 
Device: Flame 2.2 user [Affected]
Build ID               20150427002504
Gaia Revision          265ca0bc9408c21fc4b25a259fcee7fb642cd06b
Gaia Date              2015-04-24 19:13:28
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1908685d798d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150427.040119
Firmware Date          Mon Apr 27 04:01:31 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 2.1 user[This text content on flame 2.1 is different from flame 2.2]
Build ID               20150427001201
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/82a14be0462c
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150427.034910
Firmware Date          Mon Apr 27 03:49:21 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
12807

[8.Note]:
Text content on flame 2.1 is : "cannot use SD card because USB storage is enabled".

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Localizer used 2 different strings, which is why this seems too close to the edge of the string in 2.2.
ASking pt-PT localizer if he can shorten the string back. Thanks!

Comment 2

[Cláudio Esperança [:cesperanc@]]

The translations are different because the original strings are also different: 

"Cannot use SD Card because USB storage is enabled", key sdUMSEnabled, v2.1
"Cannot use memory card because USB storage is enabled", key  memoryCardUMSEnabled, v2.2

However, to fix the issue, I've shortened the translation in 2.2 about six chars on the first line, so the problem should now be fixed on locamotion.

Thank you

Comment 3

[Elie]

Attachment: IMAG0811.jpg

Set System language to Portuguese Brazil,this issue exists on flame2.2
Refer to picture:IMAG0811.jpg

Flame 2.2 user:
Build ID               20150429002501
Gaia Revision          1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gaia Date              2015-04-28 19:36:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d38ff4717f39
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150429.040640
Firmware Date          Wed Apr 29 04:06:52 EDT 2015
Bootloader             L1TC000118D0

Comment 4

[Elie]

Set System language to Serbian Latin ,this issue exists on flame2.2
Refer to picture:IMAG0811.jpg

Flame 2.2 user:
Build ID               20150429002501
Gaia Revision          1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gaia Date              2015-04-28 19:36:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d38ff4717f39
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150429.040640
Firmware Date          Wed Apr 29 04:06:52 EDT 2015
Bootloader             L1TC000118D0

Comment 5

[Alissa（leave from Mozilla）]

Attachment: Portuguese Portugal_mememory_Verified.png

This issue has been verified on flame 2.2.
Reproduce rate: 0/5

Device: Flame 2.2 user[Verified]
Build ID               20150429002501
Gaia Revision          1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gaia Date              2015-04-28 19:36:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d38ff4717f39
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150429.040640
Firmware Date          Wed Apr 29 04:06:52 EDT 2015
Bootloader             L1TC000118D0

Comment 6

[Alissa（leave from Mozilla）]

Hi Cláudio, Could you help to check this issue on Serbian Latin as comment 4 descriped

Comment 7

[Cláudio Esperança [:cesperanc@]]

The problem with the Serbian Latin is very similar to the one reported for the pt-PT locale, so the issue can be a layout issue (probably the right padding of the graphic element which contains the localized text doesn't exist or it's not being properly applied, which affects the way how the text wrapping should function; or the inner element which contains the text has a size which overlaps the size of the parent).

In the pt-PT locale the issue was fixed by removing some chars which shortened the size of the first line which allowed a localized fix. However, if this is a layout issue, there is a chance the problem will appears in other languages and/or in other screens.

Maybe we need a needinfo from a developer.

Comment 8

[Francesco Lodolo [:flod]]

Operational notes for QA:
* Please take screenshots of the phone: you can do that either on the device or via Firefox and WebIDE. Opening 7 MB of a photo (PNG is for images with few details, use JPG for photos) is painful, and I assume is painful for you to attach them to Bugzilla.
* Cross-referencing locales in localization bugs is confusing, don't do that unless they're bugs filed in the products (this bug is for pt-PT, you're asking about Serbian Latin and the localizer is not here).

Bug note: this is clearly a layout bug, the message doesn't have any margin/padding on the right, and it should be filed and fixed in Firefox OS::Contacts

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks Flod for your help on this, I've already raised all this before... Moving components for this bug. Thanks

Comment 10

[Alissa（leave from Mozilla）]

Attachment: 2.2user_Greek.png

Comment 11

[Alissa（leave from Mozilla）]

Attachment: 2.2user_Portuguese from Portugal.png

Comment 12

[Alissa（leave from Mozilla）]

Attachment: 2.2user_Serbian Cyrillic.png

Comment 13

[Alissa（leave from Mozilla）]

Attachment: 2.2user_Serbian Latin.png

Comment 14

[Alissa（leave from Mozilla）]

I have verified this issue on latest user build.

It is failed verified on follow language, 2.2User[Affected], 2.1user[Unaffected]
Greek
Portuguese from Portugal
Serbian Cyrillic
Serbian Latin

It is succesfully verified on follow language:
Spanish
Russian
Bengali from India
Polish
Basque
Portuguese from Brazil
Arabic

Device: Flame 2.1 user
Build ID               20150504001200
Gaia Revision          b4a03b7ee61de5a479b3cf0916f47e91a43b0f50
Gaia Date              2015-04-30 21:31:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/03bfe12e50d0
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150504.040736
Firmware Date          Mon May  4 04:07:47 EDT 2015
Bootloader             L1TC000118D0

Device: Flame2.2 user
Build ID               20150504002502
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150504.041541
Firmware Date          Mon May  4 04:15:53 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Alissa（leave from Mozilla）]

Hi delpfine, I noticed that you've checked this issue, but have not updated it for a long time. Could you please continue following this issue?

Comment 16

[Alissa（leave from Mozilla）]

Hi Delphine, I noticed that you've checked this issue, but have not updated it for a long time. Could you please continue following this issue?

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

Nominating 2.2 for triage decision: poor UI, strings are different between both versions but they shouldn't be shifting off the screen.

Comment 18

[Johan Lorenzo [:jlorenzo]]

Reopening the bug as this concerns multiple languages.

Comment 19

[Johan Lorenzo [:jlorenzo]]

Comms triage: This is a regression which affect many non-english speakers. However, the issue is minor, and we think it's too late to block 2.2 for a misalignment, at the current stage of the release. Let's fix it in 3.0.

Comment 20

[Ronald Claveau [:sousmangoosta]]

Attachment: Screenshot of B2G v2.2 desktop build with margin-right added

Hey Alissa,

Is this what you want ?

Thanks,

Comment 21

[Ronald Claveau [:sousmangoosta]]

Attachment: Serbian Latin without margin right

Here Serbian Latin example without margin right.

Comment 22

[Ronald Claveau [:sousmangoosta]]

Attachment: Serbian Latin with margin right

Here Serbian Latin with margin right, is it ok ?

Comment 23

[Alissa（leave from Mozilla）]

(In reply to Ronald Claveau [:sousmangoosta] from comment #20)
> Created attachment 8613290 [details]
> Screenshot of B2G v2.2 desktop build with margin-right added
> Hey Alissa,
> Is this what you want ?
> Thanks,

Hi Ronald,
Attachment 8613290 [details] looks good to me.


(In reply to Ronald Claveau [:sousmangoosta] from comment #21)
> Created attachment 8613303 [details]
> Serbian Latin without margin right
> Here Serbian Latin example without margin right.
(In reply to Ronald Claveau [:sousmangoosta] from comment #22)
> Created attachment 8613304 [details]
> Serbian Latin with margin right
> Here Serbian Latin with margin right, is it ok ?

For the two designs, attachment 8613304 [details] which with mergin right is good to me. thanks.

Comment 24

[Ronald Claveau [:sousmangoosta]]

Hey Francisco,

Could you please assign to me this bug ?

Thx you !!

Comment 25

[GitHub Autolander Bot]

Attachment: [gaia] sousmangoosta:Bug-1159170 > mozilla-b2g:master

Comment 26

[Francisco Jordano [:arcturus] [:francisco]]

A pleasure!

Comment 27

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8613408 [details] [review]
[gaia] sousmangoosta:Bug-1159170 > mozilla-b2g:master

tested on the phone, looking good for me.

Thanks for the contribution!

Comment 28

[Francisco Jordano [:arcturus] [:francisco]]

Oh,

forgot that autolander is off!

Will land manually.

Comment 29

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b

Comment 30

[Alissa（leave from Mozilla）]

We will verify this issue on master once Bug 1169815 or Bug 1171768 is fixed.

Comment 31

[Alissa（leave from Mozilla）]

This issue has been verified as pass on flame 3.0 user build.
Rate:0/5
Device: Flame 3.0 user[pass]
Build ID               20150614010203
Gaia Revision          1bf2da102560481748ff3f6202fbed5c4daa5832
Gaia Date              2015-06-13 00:22:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c223b8844264
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150614.043102
Firmware Date          Sun Jun 14 04:31:14 EDT 2015
Bootloader             L1TC000118D0

Comment 32

[Alissa（leave from Mozilla）]

Attachment: Verify1_pass_v3.0.png